You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Janne Jalkanen (JIRA)" <ji...@apache.org> on 2007/11/08 14:26:50 UTC
[jira] Created: (JSPWIKI-27) RecentChanges changenote is random
RecentChanges changenote is random
----------------------------------
Key: JSPWIKI-27
URL: https://issues.apache.org/jira/browse/JSPWIKI-27
Project: JSPWiki
Issue Type: Bug
Affects Versions: 2.5.139-beta
Reporter: Janne Jalkanen
The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627216#action_12627216 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
This is BTW a good example when two separate bugs with the exact same end result can make it really, really hard to debug something...
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen wrote:
>> My guess is that it's a caching issue, some kind of lack of
>> synchronization
>> between perhaps a WikiContext, ReferenceManager or some place that keeps
>> page information and the updating of the comments following an edit.
>> If you
>> followed a comment through the entire process of user entry to being
>> stored
>> in the provider it would seem somewhere along that chain something is
>> remaining from a previous edit. I wonder if this (a) still happens when
>> caching is turned off, and (b) if it's influenced by choice of provider.
>
> Note that if you watch the page history, that gives you the right
> results. So I don't still quite understand how one place can give you
> the right results; one gives you the wrong one.
I'm wondering if it's in the WikiEngine or in RecentChangesPlugin. Here's
a few snippets from the latter:
Collection changes = engine.getRecentChanges();
[...]
for( Iterator i = changes.iterator(); i.hasNext(); )
{
WikiPage pageref = (WikiPage)i.next();
[...]
// Change note
if( showChangenote )
{
String changenote = (String)pageref.getAttribute(WikiPage.CHANGENOTE);
row.addElement( new td(changenote != null ? TextUtil.replaceEntities(changenote) : "").setClass("changenote") );
}
It seems that 'pageref' is either getting the CHANGENOTE attribute off of
the wrong pageref, the pageref is referring to the wrong page, or the
content of the 'changes' Collection is wrong as received from the WikiEngine.
Since the latter doesn't make a lot of sense (since the plugin seems to work
for all the other page information that gets displayed), that would suggest
that 'pageref' doesn't contain the correct value for CHANGENOTE or the method
by which attributes are pulled from WikiPage objects has a problem, or the
creation of WikiPage objects themselves (i.e., how their content is obtained
from the provider).
Hope that's helpful,
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: [jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
> My guess is that it's a caching issue, some kind of lack of
> synchronization
> between perhaps a WikiContext, ReferenceManager or some place that
> keeps
> page information and the updating of the comments following an
> edit. If you
> followed a comment through the entire process of user entry to
> being stored
> in the provider it would seem somewhere along that chain something is
> remaining from a previous edit. I wonder if this (a) still happens
> when
> caching is turned off, and (b) if it's influenced by choice of
> provider.
Note that if you watch the page history, that gives you the right
results. So I don't still quite understand how one place can give
you the right results; one gives you the wrong one.
/Janne
Re: [jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605161#action_12605161 ]
>
> Janne Jalkanen commented on JSPWIKI-27:
> ---------------------------------------
>
> Nope. It's still happening. I have *no* idea what is going on.
My guess is that it's a caching issue, some kind of lack of synchronization
between perhaps a WikiContext, ReferenceManager or some place that keeps
page information and the updating of the comments following an edit. If you
followed a comment through the entire process of user entry to being stored
in the provider it would seem somewhere along that chain something is
remaining from a previous edit. I wonder if this (a) still happens when
caching is turned off, and (b) if it's influenced by choice of provider.
This has been going on for a *long* time though, many moons.
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605161#action_12605161 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
Nope. It's still happening. I have *no* idea what is going on.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554381 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
I can confirm this is occurring in 2.6.0 as well. It seems to occur whenever a spammer fails to modify a page - perhaps the RedirectException is messing something?
It also seems to affect all pages at once, so it's probably a caching issue.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Priority: Minor
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603322#action_12603322 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
I hope there's a fix in 2.7.0-svn-34; but I am not certain.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626169#action_12626169 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
Nope. Still appears, though it takes a bit more time to show up than before.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8.1
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624119#action_12624119 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
I think this was after all a different bug from the ACL issue. This should now be fixed in 2.7.0-alpha-22, but I'm keeping it open until further notice.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8.1
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627213#action_12627213 ]
Janne Jalkanen commented on JSPWIKI-27:
---------------------------------------
It would appear that I nailed this one - ReferenceManager was happily loading *old* page information when the wiki was restarted from the serialization store. The problem was that if someone didn't add a changenote, that information was not saved at serialization.
Should be fixed in 2.7.0-alpha-32.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606990#action_12606990 ]
Florian Holeczek commented on JSPWIKI-27:
-----------------------------------------
Maybe this problem occurs with ACLs, too. See the following mail from the thread "access rights problem again" on the dev list:
So is mine now. I have no idea what happened there, it's almost like someone accidentally retrieved an old version from the cache.
That could be related to JSPWIKI-27...
/Janne
On 21 Jun 2008, at 11:55, Florian Holeczek wrote:
> Well that's REALLY weird now...
> "My" JSPWikiFeatures has a different ACL!
>> [{ALLOW view All}]
>> [{ALLOW edit Asserted}]
> Regards,
> Florian
> Ursprüngliche Nachricht vom 21.06.2008 um 10:39:
>> JSPWikiFeatures has the following ACL:
>> [{ALLOW view All}]
>> [{ALLOW edit Admin,DavidAu,JanneJalkanen,HarryMetske}]
>> I don't think you were supposed to be allowed to edit it...
>> /Janne
>> On 21 Jun 2008, at 11:31, Florian Holeczek wrote:
>>> Hi all,
>>>
>>> I've just been experiencing my old access rights problem again (see
>>> thread "access rights for editing") on the following page:
>>>
>>> http://www.jspwiki.org/wiki/JSPWikiFeatures
>>>
>>> (2007-06-21, about 10:20 am)
>>>
>>> Janne, I remember you fixed something, but I don't remember if this
>>> fix affected the version running on jspwiki.org at the moment.
>>>
>>> Regards,
>>> Florian
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8.1
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-27) RecentChanges changenote is random
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen resolved JSPWIKI-27.
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.8.1)
2.8
Should be fixed in 2.7.0-alpha-32.
> RecentChanges changenote is random
> ----------------------------------
>
> Key: JSPWIKI-27
> URL: https://issues.apache.org/jira/browse/JSPWIKI-27
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.5.139-beta
> Reporter: Janne Jalkanen
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> The changenote on RecentChanges seems to be sometimes the last issued comment. For example, if version 21 had a comment "Foo", then the recentchanges will show even at version 29 the comment "Foo". However, this does not seem to occur always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.