You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/06/26 03:30:29 UTC
[jira] Created: (HARMONY-656) JIRA report: Remove one "FIXME" from
SocketChannelTest.java
JIRA report: Remove one "FIXME" from SocketChannelTest.java
-----------------------------------------------------------
Key: HARMONY-656
URL: http://issues.apache.org/jira/browse/HARMONY-656
Project: Harmony
Type: Test
Components: Classlib
Reporter: Andrew Zhang
There is a "FIXME" in assertSocketBeforeConnect method of SocketChannelTest class:
"FIXME -1 means not yet bound. this maybe a bug of RI. RI can't pass this, it returns 0."
This issue has been discussed on dev mailing list, "Bug to bug compatibility: SocketChannel.socket().getLocalPort() returns 0 while Harmony returns -1" thread.
I'll remove the "FIXME" and leave the description as comments.
Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-656) JIRA report: Remove one "FIXME"
from SocketChannelTest.java
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-656?page=comments#action_12417748 ]
Andrew Zhang commented on HARMONY-656:
--------------------------------------
Hello Nathan,
The fix looks good, thanks a lot!
Best regards,
Andrew
> JIRA report: Remove one "FIXME" from SocketChannelTest.java
> -----------------------------------------------------------
>
> Key: HARMONY-656
> URL: http://issues.apache.org/jira/browse/HARMONY-656
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: Nathan Beyer
> Attachments: nio.diff
>
> There is a "FIXME" in assertSocketBeforeConnect method of SocketChannelTest class:
> "FIXME -1 means not yet bound. this maybe a bug of RI. RI can't pass this, it returns 0."
> This issue has been discussed on dev mailing list, "Bug to bug compatibility: SocketChannel.socket().getLocalPort() returns 0 while Harmony returns -1" thread.
> I'll remove the "FIXME" and leave the description as comments.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-656) JIRA report: Remove one "FIXME" from
SocketChannelTest.java
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-656?page=all ]
Andrew Zhang updated HARMONY-656:
---------------------------------
Attachment: nio.diff
Hello,
Would you please try my patch?
Thanks a lot!
Best regards,
Andrew
> JIRA report: Remove one "FIXME" from SocketChannelTest.java
> -----------------------------------------------------------
>
> Key: HARMONY-656
> URL: http://issues.apache.org/jira/browse/HARMONY-656
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: nio.diff
>
> There is a "FIXME" in assertSocketBeforeConnect method of SocketChannelTest class:
> "FIXME -1 means not yet bound. this maybe a bug of RI. RI can't pass this, it returns 0."
> This issue has been discussed on dev mailing list, "Bug to bug compatibility: SocketChannel.socket().getLocalPort() returns 0 while Harmony returns -1" thread.
> I'll remove the "FIXME" and leave the description as comments.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-656) JIRA report: Remove one "FIXME" from
SocketChannelTest.java
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-656?page=all ]
Nathan Beyer resolved HARMONY-656:
----------------------------------
Resolution: Fixed
Patch applied at r417146. Please check that it's applied as expected.
> JIRA report: Remove one "FIXME" from SocketChannelTest.java
> -----------------------------------------------------------
>
> Key: HARMONY-656
> URL: http://issues.apache.org/jira/browse/HARMONY-656
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: Nathan Beyer
> Attachments: nio.diff
>
> There is a "FIXME" in assertSocketBeforeConnect method of SocketChannelTest class:
> "FIXME -1 means not yet bound. this maybe a bug of RI. RI can't pass this, it returns 0."
> This issue has been discussed on dev mailing list, "Bug to bug compatibility: SocketChannel.socket().getLocalPort() returns 0 while Harmony returns -1" thread.
> I'll remove the "FIXME" and leave the description as comments.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-656) JIRA report: Remove one "FIXME" from
SocketChannelTest.java
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-656?page=all ]
Nathan Beyer reassigned HARMONY-656:
------------------------------------
Assign To: Nathan Beyer
> JIRA report: Remove one "FIXME" from SocketChannelTest.java
> -----------------------------------------------------------
>
> Key: HARMONY-656
> URL: http://issues.apache.org/jira/browse/HARMONY-656
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: Nathan Beyer
> Attachments: nio.diff
>
> There is a "FIXME" in assertSocketBeforeConnect method of SocketChannelTest class:
> "FIXME -1 means not yet bound. this maybe a bug of RI. RI can't pass this, it returns 0."
> This issue has been discussed on dev mailing list, "Bug to bug compatibility: SocketChannel.socket().getLocalPort() returns 0 while Harmony returns -1" thread.
> I'll remove the "FIXME" and leave the description as comments.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-656) JIRA report: Remove one "FIXME" from
SocketChannelTest.java
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-656?page=all ]
Nathan Beyer closed HARMONY-656:
--------------------------------
Verified.
> JIRA report: Remove one "FIXME" from SocketChannelTest.java
> -----------------------------------------------------------
>
> Key: HARMONY-656
> URL: http://issues.apache.org/jira/browse/HARMONY-656
> Project: Harmony
> Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: Nathan Beyer
> Attachments: nio.diff
>
> There is a "FIXME" in assertSocketBeforeConnect method of SocketChannelTest class:
> "FIXME -1 means not yet bound. this maybe a bug of RI. RI can't pass this, it returns 0."
> This issue has been discussed on dev mailing list, "Bug to bug compatibility: SocketChannel.socket().getLocalPort() returns 0 while Harmony returns -1" thread.
> I'll remove the "FIXME" and leave the description as comments.
> Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira