You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/10 09:44:48 UTC
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #429: release 0.6.0
gxthrj opened a new pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629228285
##########
File path: CHANGELOG.md
##########
@@ -19,12 +19,32 @@
# Table of Contents
+- [0.6.0](#060)
- [0.5.0](#050)
- [0.4.0](#040)
- [0.3.0](#030)
- [0.2.0](#020)
- [0.1.0](#010)
+# 0.6.0
+
+这个版本我们新增了一些特性，修复了一些bug,同时也对内部代码做了一些优化。
Review comment:
yep
##########
File path: CHANGELOG.md
##########
@@ -19,12 +19,32 @@
# Table of Contents
+- [0.6.0](#060)
- [0.5.0](#050)
- [0.4.0](#040)
- [0.3.0](#030)
- [0.2.0](#020)
- [0.1.0](#010)
+# 0.6.0
+
+这个版本我们新增了一些特性，修复了一些bug,同时也对内部代码做了一些优化。
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836568318
> @gxthrj Should also change the document to tell people the compatibility relationship between APISIX and apisix-ingress-controller.
changed, apisix-ingress-controller 0.6 with apisix 2.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836484350
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#429](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7bb4934) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 36.58% 36.58%
=======================================
Files 43 43
Lines 3799 3799
=======================================
Hits 1390 1390
Misses 2230 2230
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...7bb4934](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836484350
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#429](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5820f31) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 36.58% 36.60% +0.01%
==========================================
Files 43 44 +1
Lines 3799 3800 +1
==========================================
+ Hits 1390 1391 +1
Misses 2230 2230
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...5820f31](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629222542
##########
File path: CHANGELOG.md
##########
@@ -19,12 +19,32 @@
# Table of Contents
+- [0.6.0](#060)
- [0.5.0](#050)
- [0.4.0](#040)
- [0.3.0](#030)
- [0.2.0](#020)
- [0.1.0](#010)
+# 0.6.0
+
+这个版本我们新增了一些特性，修复了一些bug,同时也对内部代码做了一些优化。
Review comment:
In English?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836563108
@gxthrj Should also change the document to tell people the compatibility relationship between APISIX and apisix-ingress-controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#issuecomment-836484350
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#429](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5820f31) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/dc43be89879d09dabb13626a191af72418ca730e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc43be8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 36.58% 36.58%
=======================================
Files 43 43
Lines 3799 3799
=======================================
Hits 1390 1390
Misses 2230 2230
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc43be8...5820f31](https://codecov.io/gh/apache/apisix-ingress-controller/pull/429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629269285
##########
File path: CHANGELOG.md
##########
@@ -19,12 +19,32 @@
# Table of Contents
+- [0.6.0](#060)
- [0.5.0](#050)
- [0.4.0](#040)
- [0.3.0](#030)
- [0.2.0](#020)
- [0.1.0](#010)
+# 0.6.0
+
+We have added some new features, fixed some bugs, and made some optimizations to the internal code.
Review comment:
Should tell people, CRDs were changed, should re-apply them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #429: release 0.6.0
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #429:
URL: https://github.com/apache/apisix-ingress-controller/pull/429#discussion_r629274934
##########
File path: CHANGELOG.md
##########
@@ -19,12 +19,32 @@
# Table of Contents
+- [0.6.0](#060)
- [0.5.0](#050)
- [0.4.0](#040)
- [0.3.0](#030)
- [0.2.0](#020)
- [0.1.0](#010)
+# 0.6.0
+
+We have added some new features, fixed some bugs, and made some optimizations to the internal code.
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org