You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/06 19:15:44 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10473: feat: refactor error components and add database issue code
codecov-commenter commented on pull request #10473:
URL: https://github.com/apache/incubator-superset/pull/10473#issuecomment-670143385
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=h1) Report
> Merging [#10473](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9914ae1b527d176851f5720e5789ef30288bb41e&el=desc) will **decrease** coverage by `5.32%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10473 +/- ##
==========================================
- Coverage 64.29% 58.96% -5.33%
==========================================
Files 544 354 -190
Lines 30586 22784 -7802
Branches 2885 0 -2885
==========================================
- Hits 19665 13435 -6230
+ Misses 10743 9349 -1394
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `58.96% <93.33%> (-10.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <ø> (+6.25%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <50.00%> (+0.31%)` | :arrow_up: |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `86.36% <100.00%> (+0.64%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.35% <100.00%> (+2.80%)` | :arrow_up: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `95.23% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `94.44% <100.00%> (+0.32%)` | :arrow_up: |
| [superset/db\_engine\_specs/cockroachdb.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | `90.90% <100.00%> (+0.90%)` | :arrow_up: |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `87.50% <100.00%> (+1.78%)` | :arrow_up: |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `82.14% <100.00%> (+0.66%)` | :arrow_up: |
| ... and [578 more](https://codecov.io/gh/apache/incubator-superset/pull/10473/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=footer). Last update [9914ae1...929dcd3](https://codecov.io/gh/apache/incubator-superset/pull/10473?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org