You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/16 18:29:07 UTC

[jira] [Commented] (AIRAVATA-2619) Refactoring App Catalog implementation

    [ https://issues.apache.org/jira/browse/AIRAVATA-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327539#comment-16327539 ] 

ASF GitHub Bot commented on AIRAVATA-2619:
------------------------------------------

sachinkariyattin opened a new pull request #159: [AIRAVATA-2619] Refactoring App Catalog implementation - ComputeResource
URL: https://github.com/apache/airavata/pull/159
 
 
   The pull request contains the registry refactoring changes for the _AppCatalog->ComputeResourceRepository_.  `ComputeResourceRepository `has been implemented instead of the existing Impl implementation and the changes have been done to the RegistryServiceHandler to call this repository class instead of the `ComputeResourceImpl`.
   
   **Changes:**
   
   - Added `ComputeResourceRepository `class .(_app_catalog/ComputeResourceRepository .java_) and implemented all the required CPI methods.
   - Added tests for the ComputeResourceRepository (`ComputeResourceRepositoryTest`)
   - Made required changes to `GatewayResourceProfileRepository ` and tests after this implementation.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactoring App Catalog implementation
> --------------------------------------
>
>                 Key: AIRAVATA-2619
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2619
>             Project: Airavata
>          Issue Type: Sub-task
>            Reporter: Sachin Kariyattin
>            Assignee: Sachin Kariyattin
>            Priority: Major
>
> The app catalog module contains the following Impl classes.
> {quote}ApplicationDeploymentImpl
>  ApplicationInterfaceImpl
>  ComputeResourceImpl
>  GwyResourceProfileImpl
>  StorageResourceImpl
>  UsrResourceProfileImpl
> {quote}
> This task involves creating a repository class for app catalog and include all the methods from the Impl classes mentioned above. As a modular approach is being followed, to start of, only methods GwyResourceProfileImpl will be considered. So the RegistryServiceHandler methods only with respect to GwyResourceProfileImpl will be modified. Subsequently all methods related to app catalog will be refactored.
> *Progress*:
>  * Implemeted GatewayResourceProfileRepository.
>  * Implemented ComputeResourceRepository.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)