You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@liminal.apache.org by GitBox <gi...@apache.org> on 2021/05/28 16:53:02 UTC

[GitHub] [incubator-liminal] naturalett commented on a change in pull request #41: [LIMINAL-73] post install dep for liminals_dags

naturalett commented on a change in pull request #41:
URL: https://github.com/apache/incubator-liminal/pull/41#discussion_r641687704



##########
File path: setup.py
##########
@@ -20,7 +20,18 @@
 import logging
 import os
 
-import setuptools
+import setuptools, subprocess
+from setuptools.command.install import install
+from distutils.sysconfig import get_python_lib
+
+LIMINAL_HOME_DAG="/opt/airflow/dags/liminal_dags.py"

Review comment:
       The only indication about the dags dir can come from the requirements that we installed like [apache-airflow](https://github.com/apache/incubator-liminal/blob/master/requirements.txt#L20)
   and even then the post installation is happening before the requirements.
    
   WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org