You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/16 16:18:10 UTC
[GitHub] [shardingsphere] fbin87 opened a new pull request, #22222: Fix metaspace out of memory error (#22196)
fbin87 opened a new pull request, #22222:
URL: https://github.com/apache/shardingsphere/pull/22222
* avoid compiling all input strings.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] fbin87 commented on pull request #22222: Fix metaspace out of memory error (#22196)
Posted by GitBox <gi...@apache.org>.
fbin87 commented on PR #22222:
URL: https://github.com/apache/shardingsphere/pull/22222#issuecomment-1320780022
@tuichenchuxin check and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #22222: Fix metaspace out of memory error (#22196)
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #22222:
URL: https://github.com/apache/shardingsphere/pull/22222#issuecomment-1567689906
Close due to no response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #22222: Fix metaspace out of memory error (#22196)
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #22222:
URL: https://github.com/apache/shardingsphere/pull/22222#issuecomment-1333314729
Hi @fbin87
How is going?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22222: Fix metaspace out of memory error (#22196)
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22222:
URL: https://github.com/apache/shardingsphere/pull/22222#discussion_r1027172221
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/expr/InlineExpressionParser.java:
##########
@@ -65,7 +65,15 @@ public static String handlePlaceHolder(final String inlineExpression) {
* @return result list
*/
public List<String> splitAndEvaluate() {
- return Strings.isNullOrEmpty(inlineExpression) ? Collections.emptyList() : flatten(evaluate(split()));
+ if(Strings.isNullOrEmpty(inlineExpression) ){
Review Comment:
Can you add some unit test for this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN closed pull request #22222: Fix metaspace out of memory error (#22196)
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN closed pull request #22222: Fix metaspace out of memory error (#22196)
URL: https://github.com/apache/shardingsphere/pull/22222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] fbin87 commented on a diff in pull request #22222: Fix metaspace out of memory error (#22196)
Posted by GitBox <gi...@apache.org>.
fbin87 commented on code in PR #22222:
URL: https://github.com/apache/shardingsphere/pull/22222#discussion_r1028213216
##########
infra/util/src/main/java/org/apache/shardingsphere/infra/util/expr/InlineExpressionParser.java:
##########
@@ -65,7 +65,15 @@ public static String handlePlaceHolder(final String inlineExpression) {
* @return result list
*/
public List<String> splitAndEvaluate() {
- return Strings.isNullOrEmpty(inlineExpression) ? Collections.emptyList() : flatten(evaluate(split()));
+ if(Strings.isNullOrEmpty(inlineExpression) ){
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org