You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Dmitriy Pavlov (JIRA)" <ji...@apache.org> on 2019/01/03 20:13:00 UTC
[jira] [Commented] (IGNITE-10748) Remove dead code in
TcpCommunicationSpi for the tcp client creation flow
[ https://issues.apache.org/jira/browse/IGNITE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733479#comment-16733479 ]
Dmitriy Pavlov commented on IGNITE-10748:
-----------------------------------------
[~sergey-chugunov], maybe you can review. Would you have spare cycles to burn?
> Remove dead code in TcpCommunicationSpi for the tcp client creation flow
> ------------------------------------------------------------------------
>
> Key: IGNITE-10748
> URL: https://issues.apache.org/jira/browse/IGNITE-10748
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Minor
> Fix For: 2.8
>
>
> Currently, a batch of changes can be applied over {{TcpCommunicationSpi}} class implementation due to:
> # {{safeTcpHandshake(..)}}
> #* {{handshakeConnIdx}} - parameter is always not null
> #* {{recovery}} - parameter is always not null
> #* {{HandhakeMessage}} - is not used in current flow at all
> # {{HandshakeMessage2}}
> #* Message size must be defined in the message class as constant
> # {{createTcpClient(..)}}
> #* Instantiation of {{GridTcpNioCommunicationClient}} must be performed outside the while-loop
> # Code-style issues. Fix one-liner if statements.
> # Extract internal {{HandshakeException}}, {{HandshakeTimeoutException}} from class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)