You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2026/05/09 09:11:25 UTC
[PR] Add extract column logic for window function in ColumnExtractor [shardingsphere]
strongduanmu opened a new pull request, #38681:
URL: https://github.com/apache/shardingsphere/pull/38681
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- Add extract column logic for window function in ColumnExtractor
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add extract column logic for window function in ColumnExtractor [shardingsphere]
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 merged PR #38681:
URL: https://github.com/apache/shardingsphere/pull/38681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add extract column logic for window function in ColumnExtractor [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #38681:
URL: https://github.com/apache/shardingsphere/pull/38681#issuecomment-4412233225
Merge Verdict: Mergeable
Reviewed Scope: `ColumnExtractor` and `ColumnExtractorTest`.
Not Reviewed Scope: end-to-end SELECT extraction, parser visitor behavior, and dialect-specific named window resolution.
Need Expert Review: No.
This change is focused and reasonable for `ColumnExtractor.extract(ExpressionSegment)`. It adds traversal for window function columns from:
- function / aggregation parameters
- `PARTITION BY`
- window `ORDER BY`
- frame clause expression
The added tests cover both `AggregationProjectionSegment` and `FunctionSegment` with window metadata, including partition/order/frame extraction. Existing no-window extraction behavior remains covered by the current cases.
Pre-merge checks reviewed:
- GitHub CI on latest head: success
- Local targeted test: `./mvnw -pl parser/sql/statement/core -am -DskipITs -Dspotless.skip=true -Dtest=ColumnExtractorTest -Dsurefire.failIfNoSpecifiedTests=false test` passed
- Local Checkstyle: `./mvnw -pl parser/sql/statement/core -am -Pcheck -DskipTests checkstyle:check` passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org