You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/21 18:43:56 UTC
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15774
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
[HybridClockTest] update TestNtpDiagnostics scenario
This changelist updates HybridClockTest.TestNtpDiagnostics scenario
to work even in the NTP diagnostic tools are absent. The idea is
to verify that appropriate tools are run or attempted to run, and
that's already enough.
The motivation for this changelist was the absence of ntptime, ntpq,
and other NTP-related tools in macOS Catalina and newer. As for the
deprecation of ntpd on macOS, it's replaced with timed [1] starting
macOS HighSierra (10.13). The ntpd and legacy NTP tools are there
in macOS HighSierra, but ntpd is longer running (timed is used instead).
It seems staring Catalina they removed ntpd and the legacy NTP tools such
as ntptime, ntpq, ntpdc, etc.
[1] https://forums.developer.apple.com/thread/83240
Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/15774/1
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15774 )
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15774/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15774/1//COMMIT_MSG@10
PS1, Line 10: in
> nit: if
Done
http://gerrit.cloudera.org:8080/#/c/15774/1//COMMIT_MSG@19
PS1, Line 19: staring
> nit: starting with
Done
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 Apr 2020 19:08:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15774 )
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 19:28:12 +0000
Gerrit-HasComments: No
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15774
to look at the new patch set (#2).
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
[HybridClockTest] update TestNtpDiagnostics scenario
This changelist updates HybridClockTest.TestNtpDiagnostics scenario
to work even if the NTP diagnostic tools are absent. The idea is
to verify that appropriate tools are run or attempted to run, and
that's already enough.
The motivation for this changelist was the absence of 'ntptime', 'ntpq',
and other NTP-related tools in macOS Catalina and newer. As for the
deprecation of 'ntpd' on macOS, it's replaced with 'timed' [1] starting
macOS HighSierra (10.13). The 'ntpd' and legacy NTP tools are still
there in macOS HighSierra, but 'ntpd' is longer running ('timed' is used
instead). It seems starting with Catalina they removed 'ntpd' and the
legacy NTP tools such as 'ntptime', 'ntpq', 'ntpdc', etc.
[1] https://forums.developer.apple.com/thread/83240
Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/15774/2
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15774 )
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
Patch Set 2: Verified+1
Unrelated build breakage:
12:40:24 cp: cannot stat '/home/jenkins-slave/workspace/kudu-master/0/java/kudu-subprocess/build/libs/kudu-subprocess-1.13.0-SNAPSHOT.jar': No such file or directory
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 20:14:48 +0000
Gerrit-HasComments: No
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15774 )
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
[HybridClockTest] update TestNtpDiagnostics scenario
This changelist updates HybridClockTest.TestNtpDiagnostics scenario
to work even if the NTP diagnostic tools are absent. The idea is
to verify that appropriate tools are run or attempted to run, and
that's already enough.
The motivation for this changelist was the absence of 'ntptime', 'ntpq',
and other NTP-related tools in macOS Catalina and newer. As for the
deprecation of 'ntpd' on macOS, it's replaced with 'timed' [1] starting
macOS HighSierra (10.13). The 'ntpd' and legacy NTP tools are still
there in macOS HighSierra, but 'ntpd' is longer running ('timed' is used
instead). It seems starting with Catalina they removed 'ntpd' and the
legacy NTP tools such as 'ntptime', 'ntpq', 'ntpdc', etc.
[1] https://forums.developer.apple.com/thread/83240
Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Reviewed-on: http://gerrit.cloudera.org:8080/15774
Reviewed-by: Volodymyr Verovkin <ve...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/clock/hybrid_clock-test.cc
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Volodymyr Verovkin: Looks good to me, but someone else must approve
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15774 )
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Verified this works on my laptop running Catalina
http://gerrit.cloudera.org:8080/#/c/15774/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15774/1//COMMIT_MSG@10
PS1, Line 10: in
nit: if
http://gerrit.cloudera.org:8080/#/c/15774/1//COMMIT_MSG@19
PS1, Line 19: staring
nit: starting with
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 21 Apr 2020 18:46:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [HybridClockTest] update TestNtpDiagnostics scenario
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15774 )
Change subject: [HybridClockTest] update TestNtpDiagnostics scenario
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb3467ce289eaaf394add0a72fbf5022a96fd70
Gerrit-Change-Number: 15774
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 19:37:29 +0000
Gerrit-HasComments: No