You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/04/23 21:27:14 UTC
Review Request 33489: RU: desired stack must be cascaded during
upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-10005
https://issues.apache.org/jira/browse/AMBARI-10005
Repository: ambari
Description
-------
* Cascade the desired stack id to sub-objects: service, component, host_component
* New configs should only be added on upgrade, not downgrade (separate jira)
* Non-reportable components should be handled in Finalize
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
Diff: https://reviews.apache.org/r/33489/diff/
Testing
-------
Manual 2.2.x -> 2.2.y and 2.2 -> 2.3, automated pending
Thanks,
Nate Cole
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 23, 2015, 4:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java, line 363
> > <https://reviews.apache.org/r/33489/diff/1/?file=940543#file940543line363>
> >
> > This is a minor thing, but my preference is to have separate methods for error checking and updating DB.
Noted. Due to forces beyond my control, that will have to wait as we have to get 2.2 -> 2.3 working asap.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81396
-----------------------------------------------------------
On April 23, 2015, 3:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 3:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10005
> https://issues.apache.org/jira/browse/AMBARI-10005
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
>
> Diff: https://reviews.apache.org/r/33489/diff/
>
>
> Testing
> -------
>
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
>
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81396
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
<https://reviews.apache.org/r/33489/#comment131737>
This is a minor thing, but my preference is to have separate methods for error checking and updating DB.
- Alejandro Fernandez
On April 23, 2015, 7:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 7:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10005
> https://issues.apache.org/jira/browse/AMBARI-10005
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
>
> Diff: https://reviews.apache.org/r/33489/diff/
>
>
> Testing
> -------
>
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
>
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81400
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 23, 2015, 7:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 7:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10005
> https://issues.apache.org/jira/browse/AMBARI-10005
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
>
> Diff: https://reviews.apache.org/r/33489/diff/
>
>
> Testing
> -------
>
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
>
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81397
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 23, 2015, 3:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 3:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10005
> https://issues.apache.org/jira/browse/AMBARI-10005
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
>
> Diff: https://reviews.apache.org/r/33489/diff/
>
>
> Testing
> -------
>
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
>
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 23, 2015, 4:20 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, line 898
> > <https://reviews.apache.org/r/33489/diff/1/?file=940545#file940545line898>
> >
> > Would be nice to have some java doc for this function.
Javadoc is in the interface
> On April 23, 2015, 4:20 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java, line 363
> > <https://reviews.apache.org/r/33489/diff/1/?file=940543#file940543line363>
> >
> > Why is this needed here? This function is only meant to do checks, not edits.
While that's true, there is no other logical place to set the stack version for non-reporting HostComponents. Finalize overall does writes, so it didn't seem unreasonable to put it here since upgrades would be the only time that could happen (for non-reporting).
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81383
-----------------------------------------------------------
On April 23, 2015, 3:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 3:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10005
> https://issues.apache.org/jira/browse/AMBARI-10005
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
>
> Diff: https://reviews.apache.org/r/33489/diff/
>
>
> Testing
> -------
>
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
>
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81383
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/33489/#comment131723>
Removing configs is going to be interesting.
What will eventually happen once they are ready to retry upgrade again?
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
<https://reviews.apache.org/r/33489/#comment131725>
Why is this needed here? This function is only meant to do checks, not edits.
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/33489/#comment131726>
Would be nice to have some java doc for this function.
- Alejandro Fernandez
On April 23, 2015, 7:56 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 7:56 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-10005
> https://issues.apache.org/jira/browse/AMBARI-10005
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
>
> Diff: https://reviews.apache.org/r/33489/diff/
>
>
> Testing
> -------
>
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
>
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33489: RU: desired stack must be cascaded during
upgrade
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/
-----------------------------------------------------------
(Updated April 23, 2015, 3:56 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-10005
https://issues.apache.org/jira/browse/AMBARI-10005
Repository: ambari
Description
-------
* Cascade the desired stack id to sub-objects: service, component, host_component
* New configs should only be added on upgrade, not downgrade (separate jira)
* Non-reportable components should be handled in Finalize
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac
Diff: https://reviews.apache.org/r/33489/diff/
Testing (updated)
-------
Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:57.558s
[INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
[INFO] Final Memory: 40M/714M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole