You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/06/08 10:02:42 UTC
[GitHub] [rocketmq-externals] Aaron-He opened a new pull request #576: [ISSUE #573](rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
Aaron-He opened a new pull request #576:
URL: https://github.com/apache/rocketmq-externals/pull/576
## What is the purpose of the change
DefaultMQPullConsumer is deprecated after RMQ Version 4.6.0. A better implementation DefaultLitePullConsumer is recommend to use in the scenario of actively pulling messages. We can use it.
## Brief changelog
Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
## Verifying this change
Yes
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] Aaron-He commented on a change in pull request #576: [ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
Aaron-He commented on a change in pull request #576:
URL: https://github.com/apache/rocketmq-externals/pull/576#discussion_r437807450
##########
File path: rocketmq-flume/rocketmq-flume-source/src/main/java/org/apache/rocketmq/flume/ng/source/RocketMQSource.java
##########
@@ -119,31 +116,19 @@ protected Status doProcess() throws EventDeliveryException {
Map<String, String> headers;
try {
- Set<MessageQueue> queues = consumer.fetchSubscribeMessageQueues(topic);
- for (MessageQueue queue : queues) {
- long offset = getMessageQueueOffset(queue);
- PullResult pullResult = consumer.pull(queue, tag, offset, batchSize);
+ List<MessageExt> messageExts = consumer.poll();
+ for (MessageExt msg : messageExts) {
+ byte[] body = msg.getBody();
+ headers = new HashMap<>();
+ headers.put(HEADER_TOPIC_NAME, topic);
+ headers.put(HEADER_TAG_NAME, tag);
if (log.isDebugEnabled()) {
Review comment:
Yeah, got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] zongtanghu merged pull request #576: [ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
zongtanghu merged pull request #576:
URL: https://github.com/apache/rocketmq-externals/pull/576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #576: [ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #576:
URL: https://github.com/apache/rocketmq-externals/pull/576#discussion_r437222755
##########
File path: rocketmq-flume/rocketmq-flume-source/src/main/java/org/apache/rocketmq/flume/ng/source/RocketMQSource.java
##########
@@ -119,31 +116,19 @@ protected Status doProcess() throws EventDeliveryException {
Map<String, String> headers;
try {
- Set<MessageQueue> queues = consumer.fetchSubscribeMessageQueues(topic);
- for (MessageQueue queue : queues) {
- long offset = getMessageQueueOffset(queue);
- PullResult pullResult = consumer.pull(queue, tag, offset, batchSize);
+ List<MessageExt> messageExts = consumer.poll();
+ for (MessageExt msg : messageExts) {
+ byte[] body = msg.getBody();
+ headers = new HashMap<>();
+ headers.put(HEADER_TOPIC_NAME, topic);
+ headers.put(HEADER_TAG_NAME, tag);
if (log.isDebugEnabled()) {
Review comment:
You could remove this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #576: [ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #576:
URL: https://github.com/apache/rocketmq-externals/pull/576#discussion_r437833897
##########
File path: rocketmq-flume/rocketmq-flume-source/src/main/java/org/apache/rocketmq/flume/ng/source/RocketMQSource.java
##########
@@ -119,31 +116,19 @@ protected Status doProcess() throws EventDeliveryException {
Map<String, String> headers;
try {
- Set<MessageQueue> queues = consumer.fetchSubscribeMessageQueues(topic);
- for (MessageQueue queue : queues) {
- long offset = getMessageQueueOffset(queue);
- PullResult pullResult = consumer.pull(queue, tag, offset, batchSize);
+ List<MessageExt> messageExts = consumer.poll();
+ for (MessageExt msg : messageExts) {
+ byte[] body = msg.getBody();
+ headers = new HashMap<>();
+ headers.put(HEADER_TOPIC_NAME, topic);
+ headers.put(HEADER_TAG_NAME, tag);
if (log.isDebugEnabled()) {
Review comment:
Thanks, judging from the current code, especially the tests, it seems overly simplistic. I will test it as soon as possible and then consider merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] zongtanghu commented on a change in pull request #576: [ISSUE #573] (rocketmq-flume)Replace the DefaultMQPullConsumer with the DefaultLitePullConsumer
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on a change in pull request #576:
URL: https://github.com/apache/rocketmq-externals/pull/576#discussion_r440015283
##########
File path: rocketmq-flume/rocketmq-flume-source/src/main/java/org/apache/rocketmq/flume/ng/source/RocketMQSource.java
##########
@@ -119,31 +116,19 @@ protected Status doProcess() throws EventDeliveryException {
Map<String, String> headers;
try {
- Set<MessageQueue> queues = consumer.fetchSubscribeMessageQueues(topic);
- for (MessageQueue queue : queues) {
- long offset = getMessageQueueOffset(queue);
- PullResult pullResult = consumer.pull(queue, tag, offset, batchSize);
+ List<MessageExt> messageExts = consumer.poll();
+ for (MessageExt msg : messageExts) {
+ byte[] body = msg.getBody();
+ headers = new HashMap<>();
+ headers.put(HEADER_TOPIC_NAME, topic);
+ headers.put(HEADER_TAG_NAME, tag);
if (log.isDebugEnabled()) {
Review comment:
@vongosling I think, may DefaultLitePullConsumer is better to adapter this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org