[GitHub] [airflow] potiuk opened a new pull request #6696: [AIRFLOW-6128] Untangle plugins_manager and web from cyclic dependencies. Based on [AIRFLOW-6004]

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #6696: [AIRFLOW-6128] Untangle plugins_manager and web from cyclic dependencies. Based on [AIRFLOW-6004] 
URL: https://github.com/apache/airflow/pull/6696
 
 
   NOTE FOR REVIEWER - this change is based on #6596 so please take a look only at the last commit.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6128
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Plugins manager was deeply entangled via cyclic dependencies
   with airflow/_init_py and web.py.
   
   This was apparent when adding type annotations
   to the relevant packages and trying to
   standardize the way imports are done in airflow core.
   
   Also it turned out that the test plugin view in airflow RBAC
   implementation was not working since 1.10.1 - it threw "render is
   not an attribute" error - this has been fixed in this commit
   as well. See https://stackoverflow.com/questions/53701030/airflow-plugins-rbac-enabled-blueprint-not-working?answertab=active#tab-top
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services