You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2016/11/29 13:09:32 UTC

Review Request 54162: Fix markup for widgets browser

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54162/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-19011
    https://issues.apache.org/jira/browse/AMBARI-19011


Repository: ambari


Description
-------

~


Diffs
-----

  ambari-web/app/messages.js a1d84a3 
  ambari-web/app/styles/application.less d449ccb 
  ambari-web/app/styles/bootstrap_overrides.less 97c25ab 
  ambari-web/app/styles/enhanced_service_dashboard.less 870e9a8 
  ambari-web/app/styles/hosts.less 0dde61d 
  ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 3f76a0a 
  ambari-web/app/templates/main/service/widgets/create/expression.hbs 5d05b4a 
  ambari-web/app/templates/main/service/widgets/create/step1.hbs 0edc935 
  ambari-web/app/templates/main/service/widgets/create/step2.hbs aac3726 
  ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs 7d39dfc 
  ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs 4a8638c 
  ambari-web/app/templates/main/service/widgets/create/step2_number.hbs dfd86cd 
  ambari-web/app/templates/main/service/widgets/create/step2_template.hbs a743378 
  ambari-web/app/templates/main/service/widgets/create/step3.hbs 45d3142 
  ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs 7196ddb 
  ambari-web/app/views/common/chosen_plugin.js 95f6c1e 
  ambari-web/app/views/common/controls_view.js 37d7165 
  ambari-web/app/views/main/service/widgets/create/step2_view.js dbc5bc7 

Diff: https://reviews.apache.org/r/54162/diff/


Testing
-------

19935 tests complete (31 seconds)
  154 tests pending


Thanks,

Oleg Nechiporenko

Re: Review Request 54162: Fix markup for widgets browser

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54162/#review157241
-----------------------------------------------------------


Ship it!




Ship It!

- Andrii Tkach


On Nov. 29, 2016, 1:09 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54162/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 1:09 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-19011
>     https://issues.apache.org/jira/browse/AMBARI-19011
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ~
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js a1d84a3 
>   ambari-web/app/styles/application.less d449ccb 
>   ambari-web/app/styles/bootstrap_overrides.less 97c25ab 
>   ambari-web/app/styles/enhanced_service_dashboard.less 870e9a8 
>   ambari-web/app/styles/hosts.less 0dde61d 
>   ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 3f76a0a 
>   ambari-web/app/templates/main/service/widgets/create/expression.hbs 5d05b4a 
>   ambari-web/app/templates/main/service/widgets/create/step1.hbs 0edc935 
>   ambari-web/app/templates/main/service/widgets/create/step2.hbs aac3726 
>   ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs 7d39dfc 
>   ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs 4a8638c 
>   ambari-web/app/templates/main/service/widgets/create/step2_number.hbs dfd86cd 
>   ambari-web/app/templates/main/service/widgets/create/step2_template.hbs a743378 
>   ambari-web/app/templates/main/service/widgets/create/step3.hbs 45d3142 
>   ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs 7196ddb 
>   ambari-web/app/views/common/chosen_plugin.js 95f6c1e 
>   ambari-web/app/views/common/controls_view.js 37d7165 
>   ambari-web/app/views/main/service/widgets/create/step2_view.js dbc5bc7 
> 
> Diff: https://reviews.apache.org/r/54162/diff/
> 
> 
> Testing
> -------
> 
> 19935 tests complete (31 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>