You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by jm...@apache.org on 2002/01/26 20:38:30 UTC

cvs commit: jakarta-turbine-3/src/java/org/apache/turbine/services/rundata DefaultTurbineRunData.java

jmcnally    02/01/26 11:38:30

  Modified:    src/java/org/apache/turbine/services/rundata
                        DefaultTurbineRunData.java
  Log:
  In customary usage of a RunData's parameters, actions may add or remove items
  from the ParameterParser and the changes were invisible to any later use of
  the ParameterParser, by a template for example.  In the servlet2.3 spec it
  is possible to have multiple objects represent the same "request".  This
  change preserves the behavior of data.getParameters() in that it only parses
  the request upon its first invocation and later calls to data.getParameters()
  will not erase changes made by earlier modules/actions.
  
  Revision  Changes    Path
  1.10      +4 -2      jakarta-turbine-3/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
  
  Index: DefaultTurbineRunData.java
  ===================================================================
  RCS file: /home/cvs/jakarta-turbine-3/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- DefaultTurbineRunData.java	25 Jan 2002 23:36:19 -0000	1.9
  +++ DefaultTurbineRunData.java	26 Jan 2002 19:38:30 -0000	1.10
  @@ -97,7 +97,7 @@
    * @author <a href="mailto:jon@latchkey.com">Jon S. Stevens</a>
    * @author <a href="mailto:bhoeneis@ee.ethz.ch">Bernie Hoeneisen</a>
    * @author <a href="mailto:dlr@finemaltcoding.com">Daniel Rall</a>
  - * @version $Id: DefaultTurbineRunData.java,v 1.9 2002/01/25 23:36:19 jmcnally Exp $
  + * @version $Id: DefaultTurbineRunData.java,v 1.10 2002/01/26 19:38:30 jmcnally Exp $
    */
   public class DefaultTurbineRunData
       extends RecyclableSupport
  @@ -372,7 +372,9 @@
       // ***************************************
   
       /**
  -     * Gets the parameters.
  +     * Gets the parameters.  if this is the first time calling
  +     * this method since the rundata was borrowed from the pool
  +     * the request will be parsed.
        *
        * @return a parameter parser.
        */
  @@ -380,7 +382,7 @@
       {
           // Parse the parameters first, if not yet done.
           if ((this.parameters != null) &&
  -            (this.parameters.getRequest() != this.req))
  +            (this.parameters.getRequest() == null))
           {
               this.parameters.setRequest(this.req);
           }
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>