[GitHub] [spark] sunchao commented on a change in pull request #33650: [SPARK-36351][SQL] Refactor filter push down in file source v2

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #33650:
URL: https://github.com/apache/spark/pull/33650#discussion_r691797436



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala
##########
@@ -57,6 +64,27 @@ abstract class FileScanBuilder(
     StructType(fields)
   }
 
+  def pushFilters(partitionFilters: Seq[Expression], dataFilters: Seq[Expression]): Unit = {
+    this.partitionFilters = partitionFilters
+    this.dataFilters = dataFilters
+    this.pushedDataFilters = pushDataFilters(dataFilters)

Review comment:
       I feel the same way, and this can still allow us to have file data sources implementing `SupportsPushDownFilters`, correct? it feels weird that built-in data sources don't use the V2 API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org