[GitHub] [flink] echauchot commented on a diff in pull request #21037: [FLINK-29605] Allow implementers to have bounded and unbounded SourceTestSuiteBase#testSourceMetrics

[GitBox <gi...@apache.org>]

echauchot commented on code in PR #21037:
URL: https://github.com/apache/flink/pull/21037#discussion_r993500768


##########
flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java:
##########
@@ -462,11 +477,18 @@ public void testSourceMetrics(
                             // skip failed assert try
                             return false;
                         }
-                    });
+                    },
+                    METRICS_TIMEOUT,
+                    DELAY_BETWEEN_CHECKS,
+                    String.format(
+                            "Timeout while comparing source metrics with %d expected value",
+                            getTestDataSize(testRecordCollections)));

Review Comment:
   sure but if an implementor is testing his buggy source while developing it (like I did), it would be better if this test fails with the timeout rather than running into an infinite loop, no ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org