You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/02/11 19:21:44 UTC

Review Request 69947: Cloned a sealed file of launcher binary.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69947/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik, Jason Lai, Jie Yu, and James Peach.


Repository: mesos


Description
-------

Cloned this binary during mesos containerizer create and command
executor launch.

This change would copy the mesos-containerizer binary in memory,
which helps avoid the binary being overwritten.


Diffs
-----

  src/launcher/executor.cpp f962e800f23d5582b1bc04a263253893492a5054 
  src/slave/containerizer/mesos/containerizer.hpp 3102b8755c1fa3b205081d0198c6021c02d15ec6 
  src/slave/containerizer/mesos/containerizer.cpp 35f51ad33da53b3e6a8eec275fbf3e77782b0fba 


Diff: https://reviews.apache.org/r/69947/diff/1/


Testing
-------


Thanks,

Gilbert Song

Re: Review Request 69947: Cloned a sealed file of launcher binary.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69947/#review212707
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 11, 2019, 7:21 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69947/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2019, 7:21 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jason Lai, Jie Yu, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cloned this binary during mesos containerizer create and command
> executor launch.
> 
> This change would copy the mesos-containerizer binary in memory,
> which helps avoid the binary being overwritten.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp f962e800f23d5582b1bc04a263253893492a5054 
>   src/slave/containerizer/mesos/containerizer.hpp 3102b8755c1fa3b205081d0198c6021c02d15ec6 
>   src/slave/containerizer/mesos/containerizer.cpp 35f51ad33da53b3e6a8eec275fbf3e77782b0fba 
> 
> 
> Diff: https://reviews.apache.org/r/69947/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>