You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2024/12/09 18:54:10 UTC

[PR] GH-2887: Tolerate non-NFC IRIs (IRIProviderJenaIRI) [jena]

afs opened a new pull request, #2888:
URL: https://github.com/apache/jena/pull/2888

   GitHub issue resolved #2887
   
   ----
   
    - [x] Tests are included.
    - [x] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   ----
   
   See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-2887: Tolerate non-NFC IRIs (IRIProviderJenaIRI) [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #2888:
URL: https://github.com/apache/jena/pull/2888


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


Re: [PR] GH-2887: Tolerate non-NFC IRIs (IRIProviderJenaIRI) [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #2888:
URL: https://github.com/apache/jena/pull/2888#discussion_r1876827605


##########
jena-core/src/main/java/org/apache/jena/irix/IRIProviderJenaIRI.java:
##########


Review Comment:
   Use switch form that does not need "break" - clearer that "continue" is the loop.



##########
jena-core/src/main/java/org/apache/jena/irix/SetupJenaIRI.java:
##########
@@ -99,9 +99,11 @@ public static IRIFactory iriCheckerFactory() {
         setErrorWarning(iriCheckerFactory, ViolationCodes.NON_INITIAL_DOT_SEGMENT, false, false);
 
         // == Character related.
-        //setErrorWarning(iriFactoryInst, ViolationCodes.NOT_NFC,  false, false);
+        // Causes confusion! And this is only advice in RDF Concepts.
+        setErrorWarning(iriCheckerFactory, ViolationCodes.NOT_NFC,  false, false);

Review Comment:
   This is THE change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org