You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2015/04/29 03:59:16 UTC
Review Request 33656: AMS: navigating graph time ranges are not
correct
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33656/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-10809
https://issues.apache.org/jira/browse/AMBARI-10809
Repository: ambari
Description
-------
Graphs are not padding time for full range. For example: view 4 hours with a cluster is only a few hours old. The graphs don't change even thought the APIs calls are being made. The API should return padded 0 values (or the graph needs to display the full range).
Keep the existing API behavior of padding with zeros for missing data points so that this has zero impact on the UI or any other third-party code using the Ambari metrics API.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java d58d110
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 7f2b227
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsPaddingMethodTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33656/diff/
Testing
-------
Verified manually, related unit tests pass.
Thanks,
Sid Wagle
Re: Review Request 33656: AMS: navigating graph time ranges are not
correct
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33656/#review81998
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On April 29, 2015, 1:59 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33656/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 1:59 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-10809
> https://issues.apache.org/jira/browse/AMBARI-10809
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Graphs are not padding time for full range. For example: view 4 hours with a cluster is only a few hours old. The graphs don't change even thought the APIs calls are being made. The API should return padded 0 values (or the graph needs to display the full range).
>
>
> Keep the existing API behavior of padding with zeros for missing data points so that this has zero impact on the UI or any other third-party code using the Ambari metrics API.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java d58d110
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 7f2b227
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsPaddingMethodTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33656/diff/
>
>
> Testing
> -------
>
> Verified manually, related unit tests pass.
>
>
> Thanks,
>
> Sid Wagle
>
>