You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/30 11:38:52 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #2617:
[Alter Table] No need to check whether table is stable when doing some
kinds of alter operation
morningman opened a new pull request #2617: [Alter Table] No need to check whether table is stable when doing some kinds of alter operation
URL: https://github.com/apache/incubator-doris/pull/2617
Not all alter table operation require table to be stable. Such as rename, modify meta data.
ISSUE #2616
And also optimize the routine load logic so that it won't rollback a already committed transaction.
ISSUE #2527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2617:
[Alter Table] No need to check whether table is stable when doing some
kinds of alter operation
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2617: [Alter Table] No need to check whether table is stable when doing some kinds of alter operation
URL: https://github.com/apache/incubator-doris/pull/2617#discussion_r362227508
##########
File path: fe/src/main/java/org/apache/doris/analysis/AlterClause.java
##########
@@ -23,6 +23,12 @@
// Alter table clause.
public abstract class AlterClause implements ParseNode {
+ // if set to true, the corresponding table should be stable before processing this operation on it.
+ protected boolean needTableStable = false;
Review comment:
I think it's better to set this field default value true. Because if some clause don't set this false, it won't cause big problem, just can not do something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #2617: [Alter
Table] No need to check whether table is stable when doing some kinds of
alter operation
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #2617: [Alter Table] No need to check whether table is stable when doing some kinds of alter operation
URL: https://github.com/apache/incubator-doris/pull/2617
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#2617: [Alter Table] No need to check whether table is stable when doing
some kinds of alter operation
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2617: [Alter Table] No need to check whether table is stable when doing some kinds of alter operation
URL: https://github.com/apache/incubator-doris/pull/2617#discussion_r362390292
##########
File path: fe/src/main/java/org/apache/doris/analysis/AlterClause.java
##########
@@ -23,6 +23,12 @@
// Alter table clause.
public abstract class AlterClause implements ParseNode {
+ // if set to true, the corresponding table should be stable before processing this operation on it.
+ protected boolean needTableStable = false;
Review comment:
OK, I change it to default true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org