[GitHub] [spark] stczwd edited a comment on pull request #35751: [SPARK-38433][BUILD] Add shell code style check Actions

[GitBox <gi...@apache.org>]

stczwd edited a comment on pull request #35751:
URL: https://github.com/apache/spark/pull/35751#issuecomment-1061336368


   > 
   
   
   
   > Quick question: don't we have a style feature together too? I know many scripts have inconsistent styles. e.g., 2 spaces vs 4 spaces.
   
   Yes, based on [Google Shell Style Guide](https://google.github.io/styleguide/shellguide.html#s5.1-indentation), 2 spaces and no tabs for indentition. However, the `shellcheck` doesn't support this now, which means no indentition check for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org