You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@graphar.apache.org by "unical1988 (via GitHub)" <gi...@apache.org> on 2025/07/04 03:08:56 UTC

[PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

unical1988 opened a new pull request, #717:
URL: https://github.com/apache/incubator-graphar/pull/717

   This open PR is for updating the docs for newly implemented graph features (graph vertex and edge removal) in Java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "sapienza88 (via GitHub)" <gi...@apache.org>.
sapienza88 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4433218257

   @SYaoJun done! could you merge it now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4376819563

   > @SYaoJun it seems @yangxk1 forgot to merge this after the feature was updated.
   
   Hi @sapienza88, could you resolve the file conflicts first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "unical1988 (via GitHub)" <gi...@apache.org>.
unical1988 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069148740

   > @unical1988 , the `docs` should be modified after the `code` pr merge, otherwise it will cause confusion. To modify the PR of the `code`, please make sure that they can pass the CI workflows :)
   
   aside from can pass the CI workflows, pls review the PRs 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069201440

   rerun `mvn spotless:apply` and push to your branch, ci will be triggered again :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "sapienza88 (via GitHub)" <gi...@apache.org>.
sapienza88 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4428403928

   @SYaoJun merge the PR pls


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4429842826

   You could force push and remove my commit information or I have no right merge my own  changes. maybe left a single commit message is more clear. @sapienza88 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "unical1988 (via GitHub)" <gi...@apache.org>.
unical1988 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069182449

   > > > @unical1988 , the `docs` should be modified after the `code` pr merge, otherwise it will cause confusion. To modify the PR of the `code`, please make sure that they can pass the CI workflows :)
   > > 
   > > 
   > > aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer
   > 
   > For example, the following ci:
   > 
   > https://github.com/apache/incubator-graphar/actions/runs/15913059612/job/44900162946?pr=711
   > 
   > https://github.com/apache/incubator-graphar/actions/runs/16003204977/job/45210287183?pr=714
   
   These come after reviewing the code! (as a matter of fact these are formatting related issues easily solved with spotless:apply of maven.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun merged PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "unical1988 (via GitHub)" <gi...@apache.org>.
unical1988 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069209703

   > rerun `mvn spotless:apply` and push to your branch, ci will be triggered again :)
   
   I will do that but pls review the other PRs as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "unical1988 (via GitHub)" <gi...@apache.org>.
unical1988 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069126830

   @yangxk1 pls proceed to reviewing my past PRs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "sapienza88 (via GitHub)" <gi...@apache.org>.
sapienza88 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4374584766

   @SYaoJun it seems @yangxk1 forgot to merge this after the feature was updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "sapienza88 (via GitHub)" <gi...@apache.org>.
sapienza88 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3702553667

   @yangxk1 this can be merged now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "sapienza88 (via GitHub)" <gi...@apache.org>.
sapienza88 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4377175164

   @SYaoJun I am not sure where I saved the last version of this repo but "Allow edits by maintainers" is ON, you can do it for both PRs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069142293

   @unical1988 , the `docs` should be modified after the `code` pr merge, otherwise it will cause confusion. To modify the PR of the `code`, please make sure that they can pass the CI workflows :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4436439886

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "yangxk1 (via GitHub)" <gi...@apache.org>.
yangxk1 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-3069166004

   > > @unical1988 , the `docs` should be modified after the `code` pr merge, otherwise it will cause confusion. To modify the PR of the `code`, please make sure that they can pass the CI workflows :)
   > 
   > aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer
   
   For example, the following ci:
   
   https://github.com/apache/incubator-graphar/actions/runs/15913059612/job/44900162946?pr=711
   
   https://github.com/apache/incubator-graphar/actions/runs/16003204977/job/45210287183?pr=714
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4427327116

   lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4421917699

   @sapienza88 you can close the PR and create a new PR, the title check not pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] updating docs for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "SYaoJun (via GitHub)" <gi...@apache.org>.
SYaoJun commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4421890951

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org


Re: [PR] docs: update documentation for removing edge or vertex in Java in impl-stats [incubator-graphar]

Posted by "sapienza88 (via GitHub)" <gi...@apache.org>.
sapienza88 commented on PR #717:
URL: https://github.com/apache/incubator-graphar/pull/717#issuecomment-4422174862

   @SYaoJun could you try again now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@graphar.apache.org
For additional commands, e-mail: commits-help@graphar.apache.org