You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/10/10 15:39:33 UTC

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/890#discussion_r41697298
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java ---
    @@ -44,10 +44,10 @@
         /////////////////////////////////////////////////////
     
         @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = GuestOsMappingResponse.class, required = false, description = "list mapping by its UUID")
    -    private Long id;
    +    private String id;
    --- End diff --
    
    This can cause issues here, during Cmd object creation arguments values of keys ID and OS_TYPE_ID will be converted to a Long as the parameter type defined here is CommandType.UUID. 
    
    This is where this happens: https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/api/dispatch/ParamProcessWorker.java#L318
    
    If you really want Strings here, please change the @Parameter annotation type to CommandType.STRING etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---