You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by Neeme Praks <ne...@one.lv> on 2001/05/03 19:10:15 UTC
patched some minor things in svgbrowser
While going through the source code for svgbrowser, found some places with
"TODO" comments. Fixed them and here are the diffs.
Neeme
Index: Main.properties
===================================================================
RCS file:
/home/cvspublic/xml-batik/resources/org/apache/batik/apps/svgbrowser/resourc
es/Main.properties,v
retrieving revision 1.1
diff -r1.1 Main.properties
52a53,56
>
> # File (not) found
> Command.file-found = Loading file:
> Command.file-not-found = File not found or access denied:
Index: Main.java
===================================================================
RCS file:
/home/cvspublic/xml-batik/sources/org/apache/batik/apps/svgbrowser/Main.java
,v
retrieving revision 1.5
diff -r1.5 Main.java
149c149,150
< if (frame == null)
---
>
System.out.println(resources.getString("Command.file-found") +
file.getPath());
> if (frame == null)
156,157c157
< // Should let the user know that we are
< // skipping this file...
---
>
System.out.println(resources.getString("Command.file-not-found") +
file.getPath());
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: batik-dev-help@xml.apache.org
Re: patched some minor things in svgbrowser
Posted by Vincent Hardy <vh...@eng.sun.com>.
Neeme,
I just commited a change in the code that addresses the problem you
pointed out. It is slightly different from the patch you submitted in
that it does not use trace but it does fix the lack of user feedback
that you pointed out.
Thanks for your contribution!
Cheers.
V.
Neeme Praks wrote:
>
> While going through the source code for svgbrowser, found some places with
> "TODO" comments. Fixed them and here are the diffs.
>
> Neeme
>
> Index: Main.properties
> ===================================================================
> RCS file:
> /home/cvspublic/xml-batik/resources/org/apache/batik/apps/svgbrowser/resourc
> es/Main.properties,v
> retrieving revision 1.1
> diff -r1.1 Main.properties
> 52a53,56
> >
> > # File (not) found
> > Command.file-found = Loading file:
> > Command.file-not-found = File not found or access denied:
>
> Index: Main.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-batik/sources/org/apache/batik/apps/svgbrowser/Main.java
> ,v
> retrieving revision 1.5
> diff -r1.5 Main.java
> 149c149,150
> < if (frame == null)
> ---
> >
> System.out.println(resources.getString("Command.file-found") +
> file.getPath());
> > if (frame == null)
> 156,157c157
> < // Should let the user know that we are
> < // skipping this file...
> ---
> >
> System.out.println(resources.getString("Command.file-not-found") +
> file.getPath());
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
> For additional commands, e-mail: batik-dev-help@xml.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: batik-dev-help@xml.apache.org