[GitHub] [druid] lokesh-lingarajan commented on a change in pull request #11894: Modifying index from druid_segments(datasource, used, end) to druid_segments(datasource, used, end, start) to support kill task

[GitBox <gi...@apache.org>]

lokesh-lingarajan commented on a change in pull request #11894:
URL: https://github.com/apache/druid/pull/11894#discussion_r768863015



##########
File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java
##########
@@ -283,6 +283,11 @@ public void createSegmentTable(final String tableName)
                 "CREATE INDEX idx_%1$s_datasource_used_end ON %1$s(dataSource, used, %2$send%2$s)",
                 tableName,
                 getQuoteString()
+            ),
+            StringUtils.format(
+                "CREATE INDEX idx_%1$s_datasource_used_start_end ON %1$s(dataSource, used, start, %2$send%2$s)",
+                tableName,
+                getQuoteString()

Review comment:
       @FrankChen021 - Thanks for your recommendation, we tested the change of putting start at the end of the index and it worked in all our clusters. Fix is working without any issues. Please take a look at the change now :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org