[GitHub] [madlib] kaknikhil commented on a change in pull request #449: DL: Use REAL[] instead of anyarray for aggregating arrays

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #449: DL: Use REAL[] instead of anyarray for aggregating arrays
URL: https://github.com/apache/madlib/pull/449#discussion_r335109026
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/test/madlib_keras_cifar.setup.sql_in
 ##########
 @@ -46,12 +46,12 @@ CREATE TABLE cifar_10_sample_text_batched AS
 
 -- Insert a new row with NULL as the dependent var (one-hot encoded)
 UPDATE cifar_10_sample_text_batched
-	SET dependent_var = convert_array_to_bytea(ARRAY[0,0,1,0,0]::REAL[]) WHERE buffer_id=0;
+	SET dependent_var = convert_array_to_bytea(ARRAY[0,0,1,0,0]::smallint[]) WHERE buffer_id=0;
 
 Review comment:
   `convert_array_to_bytea` is overloaded and accepts both real[] and smallint[] as arg types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services