You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/21 10:08:07 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3764: feat(ci): latest runtime snapshot available
squakez opened a new pull request, #3764:
URL: https://github.com/apache/camel-k/pull/3764
<!-- Description -->
With this PR we aim to test Camel K `main` branch against the latest produced in snapshot by Camel K runtime `main`. In this way we don't have to wait the end of a release cycle to have Camel K Runtime development feedback and we may discover issues immediately when adding any change to the runtime. If we're happy with this approach, we may extend it to release branches as well and ensure that a snapshot is always pushed by Camel K runtime project.
In order to run some test, this PR is using Camel K runtime `1.15.1-SNAPSHOT` while we [upgrade it to `1.16.0-SNAPSHOT`](https://github.com/apache/camel-k-runtime/pull/909)
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(ci): latest runtime snapshot available
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291500424
@squakez Looking at the error output, they are failing because they cannot execute a local Maven project to calculate dependencies. It appears there are some problems in downloading and resolving dependencies with a snapshot runtime.
```
Error: failed to compute transitive dependencies: failure while building project: exit status 1
```
You should be able to replicate the issue locally by `kamel local run` with a snapshot runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1287050638
Yes, we need this as well: https://github.com/apache/camel-k-runtime/pull/911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez closed pull request #3764: feat(ci): latest runtime snapshot available
URL: https://github.com/apache/camel-k/pull/3764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1286742746
@claudio4j @oscerd @tadayosi wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a diff in pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#discussion_r1001616148
##########
script/maven-settings.xml:
##########
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
+ <profiles>
+ <profile>
+ <id>apache</id>
+ <repositories>
+ <repository>
+ <id>apache-snapshots</id>
+ <name>Apache Snapshots Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots-group</url>
+ <releases>
+ <enabled>false</enabled>
+ <updatePolicy>never</updatePolicy>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ <updatePolicy>always</updatePolicy>
+ </snapshots>
+ </repository>
+ <repository>
+ <id>apache-staging</id>
+ <name>Apache Staging Repository</name>
+ <url>https://repository.apache.org/content/repositories/orgapachecamel-1484</url>
Review Comment:
I think the url is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291753169
I've fixed the local problems and rebased with the new timeout increased. :crossed_fingers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#discussion_r1005446908
##########
e2e/local/util.go:
##########
@@ -58,5 +59,8 @@ func kamelWithContext(ctx context.Context, args ...string) *cobra.Command {
if runtimeRepo != "" {
args = append(args, "--maven-repository", runtimeRepo)
}
+ if runtimeVersion != "" {
Review Comment:
Do you mean `if strings.HasSuffix(runtimeVersion, "-SNAPSHOT")`? Otherwise the snapshot repo should be always setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3764:
URL: https://github.com/apache/camel-k/pull/3764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291571865
One more issue to fix is that the current maven util impl doesn't consider snapshot repos, so even if you use `--maven-repository` flag it won't work.
https://github.com/apache/camel-k/blob/main/pkg/util/maven/maven_repositories.go#L31-L76
```
/kamel local run e2e/local/files/yaml.yaml --maven-repository=https://repository.apache.org/content/repositories/snapshots-group
Error: failed to compute transitive dependencies: failure while building project: exit status 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1287000799
As there is this maven-settings.xml, the other scripts maven_overlay.sh, package_maven_artifacts.sh, can be changed to use this maven-settings.xml.
currently the `make IMAGE_NAME=apache/camel-k images-dev` fails with
```
mkdir -p build/_maven_overlay
./script/maven_overlay.sh -s "" -d "" 1.16.0-SNAPSHOT build/_maven_overlay
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:copy (default-cli) on project standalone-pom: Unable to find artifact.: org.apache.camel.k:camel-k-maven-logging:zip:1.16.0-SNAPSHOT was not found in https://maven.repository.redhat.com/earlyaccess/all/ during a previous attempt.
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1288288736
As I remember it we had been using the runtime snapshots in earlier Camel K versions. I don't know why we haven't done the same lately. Definitely a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1290756150
Some error in the `local` test:
❌ TestLocalBuild (5m0.05s)
❌ TestLocalBuildDependenciesOnly (1m0.06s)
❌ TestLocalBuildIntegrationDirectory (1m0.06s)
❌ TestLocalBuildIntegrationDirectoryWithMultiBytes (1m0.06s)
❌ TestLocalBuildIntegrationDirectoryWithSpaces (1m0.06s)
❌ TestLocalBuildModelineDependencies (1m0.06s)
✅ TestLocalBuildWithInvalidDependency (1.5s)
❌ TestLocalBuildWithTrait (5m0.07s)
✅ TestLocalInspect (140ms)
✅ TestLocalInspectWithDependencies (140ms)
❌ TestLocalRun (5m0.07s)
❌ TestLocalRunContainerize (0s)
❌ TestLocalRunWithDependencies (5m0.06s)
✅ TestLocalRunWithInvalidDependency (1.55s)
@tadayosi does it ring any bell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#discussion_r1001619067
##########
script/maven-settings.xml:
##########
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
+ <profiles>
+ <profile>
+ <id>apache</id>
+ <repositories>
+ <repository>
+ <id>apache-snapshots</id>
+ <name>Apache Snapshots Repository</name>
+ <url>https://repository.apache.org/content/repositories/snapshots-group</url>
+ <releases>
+ <enabled>false</enabled>
+ <updatePolicy>never</updatePolicy>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ <updatePolicy>always</updatePolicy>
+ </snapshots>
+ </repository>
+ <repository>
+ <id>apache-staging</id>
+ <name>Apache Staging Repository</name>
+ <url>https://repository.apache.org/content/repositories/orgapachecamel-1484</url>
Review Comment:
That URL is a placeholder. When a new staging repository is set in the `Makefile` then, it will be updated with the correct value. Likely it's the one related to some test I did to make sure it was changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1286933075
Hey @oscerd, right now the publish of Camel K runtime on snapshot always happen when a new commit is pushed to the `main` or `release` branches. If we make sure to double check any error when we merge, then, we should have a guarantee that the latest changes are in the snapshot. I'd say that it would be okey for the time being. Nevertheless, I'll create a follow up request on that project to setup a nightly snapshot, but I think we can work with a lower priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291779779
> Why not? I mean, you need to provide `--maven-repository https://repository.apache.org/content/repositories/snapshots-group@snapshots` or to expect those snapshot to be already available in your local machine. But, a part that detail, the execution should work as expected.
Yes, so from now on, we need to remeber to add `--maven-repository https://repository.apache.org/content/repositories/snapshots-group@snapshots` whenever you want to test `kamel local` with a locally built `kamel` cli. I was thinking if there's a smart way to add the snapshot repo to the default repos set so that we won't need to add `--maven-repository` manually during development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291549939
I think the root cause is the the default Maven repositories don't include https://repository.apache.org/content/repositories/snapshots-group. We'd need to find a way to include the snapshot one to the default repos only when we are in development and use a snapshot repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291604441
Thank you so much @tadayosi. I'll have a look and fix accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#discussion_r1005450630
##########
e2e/local/util.go:
##########
@@ -58,5 +59,8 @@ func kamelWithContext(ctx context.Context, args ...string) *cobra.Command {
if runtimeRepo != "" {
args = append(args, "--maven-repository", runtimeRepo)
}
+ if runtimeVersion != "" {
Review Comment:
Good one. Clearly a mistake. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291768344
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291770355
> Fixing `e2e/local/util.go` should pass the `local-it` tests but a compiled `kamel` from source won't still work with `./kamel local run`. I think we need to fix the main pkg source as well.
Why not? I mean, you need to provide `--maven-repository https://repository.apache.org/content/repositories/snapshots-group@snapshots` or to expect those snapshot to be already available in your local machine. But, a part that detail, the execution should work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1286748684
> It's a good idea, just one minor finding. We also need to be sure the deploy on snapshot always work. We need to set up a github action or ci build, to always deploy camel-k-runtime to snapshot. Every night for example.
Yes, that's correct. We already push a snapshot for Camel K runtime when we add a commit, but, it would be advisable to enable the same nightly to refresh that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1286757482
All good then. At some point we'll need to move the runtime bits in camel quarkus, so the camel k release will be easy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1292009641
It looks good now, the failing checks appears to be something flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3764: feat(ci): latest runtime snapshot available
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3764:
URL: https://github.com/apache/camel-k/pull/3764#issuecomment-1291532961
I can replicate it locally:
```
$ ./kamel local build e2e/local/files/yaml.yaml --integration-directory test
Error: failed to compute transitive dependencies: failure while building project: exit status 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org