You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/03/17 11:19:17 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #3210: HDDS-6411. EC: OmMultipartKeyInfo needs to handle ECReplicationConfig

adoroszlai opened a new pull request #3210:
URL: https://github.com/apache/ozone/pull/3210


   ## What changes were proposed in this pull request?
   
   Add ECReplicationConfig in `MultipartKeyInfo` proto message and its `OmMultipartKeyInfo` counterpart.
   
   https://issues.apache.org/jira/browse/HDDS-6411
   
   ## How was this patch tested?
   
   Added unit test.
   
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/1997562855


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #3210: HDDS-6411. EC: OmMultipartKeyInfo needs to handle ECReplicationConfig

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3210:
URL: https://github.com/apache/ozone/pull/3210#issuecomment-1073506450


   > there is MultipartUploadInfo which has factor too. Do you think we can incorporate here
   
   Maybe I'm missing something, but HDDS-6413 already added ECReplicationConfig handling in `MultipartUploadInfo`.
   
   https://github.com/apache/ozone/blob/217c1911b273018fe1a6e8b2770ab05d1247a509/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L1293-L1302
   
   https://github.com/apache/ozone/blob/217c1911b273018fe1a6e8b2770ab05d1247a509/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java#L546-L553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #3210: HDDS-6411. EC: OmMultipartKeyInfo needs to handle ECReplicationConfig

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #3210:
URL: https://github.com/apache/ozone/pull/3210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #3210: HDDS-6411. EC: OmMultipartKeyInfo needs to handle ECReplicationConfig

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3210:
URL: https://github.com/apache/ozone/pull/3210#issuecomment-1075484394


   Thanks @umamaheswararao for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai edited a comment on pull request #3210: HDDS-6411. EC: OmMultipartKeyInfo needs to handle ECReplicationConfig

Posted by GitBox <gi...@apache.org>.
adoroszlai edited a comment on pull request #3210:
URL: https://github.com/apache/ozone/pull/3210#issuecomment-1073506450


   > there is MultipartUploadInfo which has factor too. Do you think we can incorporate here
   
   Maybe I'm missing something, but HDDS-6413 already added `ECReplicationConfig` in `MultipartUploadInfo`.
   
   https://github.com/apache/ozone/blob/217c1911b273018fe1a6e8b2770ab05d1247a509/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L1293-L1302
   
   https://github.com/apache/ozone/blob/217c1911b273018fe1a6e8b2770ab05d1247a509/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java#L546-L553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org