FW: [Fwd: Issues with the Windows installer package for svn 1.4]

[Troy Simpson <tr...@ebswift.com>]

Forwarded by request from Lieven - FYI & for comment:

-----Original Message-----
From: Troy Simpson [mailto:troy@ebswift.com]
Sent: Monday, 9 October 2006 2:12 PM
To: 'Lieven Govaerts'
Subject: RE: [Fwd: Issues with the Windows installer package for svn 1.4]

Hello Lieven,

I have finally managed to cut ties with my previous website host and started
with a new host, so my email is now working properly.

I have been looking at the issues and the first thing I'd like to clarify is
that given Subversion utilises technologies that licenses need to be
distributed with, shouldn't the licenses exist in the Subversion repository
at a higher level?  No external files should really be attached to the
installer that do not exist inside the repository (except for binaries).

I see the Subversion license has been corrected in the root of the
repository ('COPYING'), so this can now be implemented.

There is a LOT of manual setup required to make a Subversion setup file, and
generally it takes a number of attempts before all pre-requisites are in
place.  I might try and see if I can simplify the installation to reduce
errors in packaging.

At this stage, considering that most problems are pre-existing, it might be
a better idea to try to fix the problems in a future installer rather than
the current one so that we can avoid packaging files from a newer trunk
(which may undergo further updates).

Once all files are inside the repository we can make minor releases if
necessary - we can make a new tag with corrections for the minor release.
We can then merge those corrections to the trunk.  Without a tag there is no
real audit trail.

I am in no position to be creating new high level folders (for license
files), so I leave that to the tree maintainers to administer.


Regards,

Troy Simpson
http://www.ebswift.com


-----Original Message-----
From: Lieven Govaerts [mailto:svnlgo@mobsol.be]
Sent: Thursday, 21 September 2006 3:51 PM
To: troy@ebswift.com
Subject: [Fwd: Issues with the Windows installer package for svn 1.4]

Hi Troy,

since you're the maintainer of the win32 package, did you notice my email on
the dev list last Sunday? I 've noticed a range of problems with the Windows
installer, which I'd like to fix. Can you validate if the problems I'm
reporting are real actual problems?

thanks,

Lieven.

-------- Original Message --------
Subject:        Issues with the Windows installer package for svn 1.4
Date:   Sat, 16 Sep 2006 21:45:05 +0200
From:   Lieven Govaerts <lg...@mobsol.be>
To:     Subversion Developers <de...@subversion.tigris.org>



Hi,


I've installed Subversion 1.4 on my Windows machine using the binaries as
provided on the s.t.o website.

During the install I noticed that the text as displayed by the installer and
the text files included in the installed package are either outdated or
incorrect (or both).

Here's a list of things I noticed:

in the .exe installer:
* the opening license doesn't have any paragraphs so it's very difficult to
read. The copyright date is 2004.

* in pre.rtf: 'Subversion are a compelling replacement', copyright date
still 2005.
I've fixed this in r21516

* in pre.rtf: 'Subversion is using some external programs and libraries
included in this package. The proper licenses are in the licenses folder in
the application path created after this installation.'
There is no such folder in the application path, only in the start menu.

* in pre.rtf: the link to CHANGES is the version on trunk instead of the
1.4 version.

* In the closing screen: 'The application may be launched by selecting the
installed icons'. I know this is standard text from the installer, but in
this case there's only a command-line tool installed.

* Buildnotes.txt: package contents list several folders which are not
installed (include, javahl, lib, perl, python). It doesn't list the helpers
folder which is installed. Why is this file called Buildnotes.txt btw? In
the zip package this content can be found in Readme.txt.

* What does the file svn-proxy-template.reg do?

* The Subversion license file isn't installed, if you click on the license
item in the start menu you get a dialog to search for that file.

* We distribute bdb 4.4 now, but the Berkely License file has 2001 as it's
copyright date, so that's clearly not up to date.

* There's no specific warning that this version uses bdb 4.4. Even the
webpages
http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=91
and http://subversion.tigris.org/project_packages.html still warn for the
upgrade of 4.2 to 4.3.

* We distribute apr in the package, and the asf license requires us (as far
as I understand it correctly) to include to license file with our
installer(s).

* We distribute neon in the package, so we should include the GPL license
file.

* The zlib library is statically build in the binary (right?), so we should
include their license file: http://www.zlib.net/zlib_license.html

* We distribute OpenSSL in the package, so we should include their
license: http://www.openssl.org/source/license.html

Note 1: some of this remarks are also applicable to the ZIP package.
Note 2: these are no new issues, apparently the 1.3.2 package has the same
problems.

We should pay much more attention to the quality of the installer, it's
people first acquaintance with the Subversion product and we don't want to
give the impression that we don't care for details, right?

Some of these things need to be checked for every release, I propose we
include those in our release checklist.

I'm willing to look into this and help fixing things but I'd like to have a
second opinion first.

regards,

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org






---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: FW: [Fwd: Issues with the Windows installer package for svn 1.4]

[Lieven Govaerts <sv...@mobsol.be>]

Troy Simpson wrote:
> I have been looking at the issues and the first thing I'd like to clarify is
> that given Subversion utilises technologies that licenses need to be
> distributed with, shouldn't the licenses exist in the Subversion repository
> at a higher level?  No external files should really be attached to the
> installer that do not exist inside the repository (except for binaries).
>   
There's no real need to store the license files in the subversion
repository, except for the fact that it makes it easier to build binary
packages. At least the license files should already be included in the
zip files (the binaries), this is not a problem that the creator of the
installer has to solve.

I propose to include the license files in a licenses folder in the zip
package, so we can extend the install script to copy all files from this
licenses folder in the installer.

These are the license files we need to include:
zlib:        http://www.zlib.net/zlib_license.html
openssl:  http://www.openssl.org/source/license.html
apr:        http://www.apache.org/licenses/LICENSE-2.0
neon:      http://www.gnu.org/licenses/lgpl.txt
bdb:      
http://www.oracle.com/technology/software/products/berkeley-db/htdocs/oslicense.html
serf:        http://svn.webdav.org/repos/projects/serf/trunk/LICENSE
(apache 2.0 license, same as apr)

subversion: http://subversion.tigris.org/license-1.html
> There is a LOT of manual setup required to make a Subversion setup file, and
> generally it takes a number of attempts before all pre-requisites are in
> place.  I might try and see if I can simplify the installation to reduce
> errors in packaging.
>   
I spent an hour this morning to download and install all tools needed to
make an installer from the zip file for 1.4.1. There are some manual
steps which can be eliminated, but all in all it's not too bad.
> At this stage, considering that most problems are pre-existing, it might be
> a better idea to try to fix the problems in a future installer rather than
> the current one so that we can avoid packaging files from a newer trunk
> (which may undergo further updates).
>   
1.4.1 is coming out in the next days, would be nice if we could at least
fix some of the most obvious stuff, like the broken link to the svn
license file, copyright dates etc.
> Once all files are inside the repository we can make minor releases if
> necessary - we can make a new tag with corrections for the minor release.
> We can then merge those corrections to the trunk.  Without a tag there is no
> real audit trail.
>   
As far as I see the installer scripts only change the week before or after a release, be it a major or minor release, so as far as I'm concerned we can always use the latest version of trunk. 

> -----Original Message-----
> From: Lieven Govaerts [mailto:svnlgo@mobsol.be]
> Sent: Thursday, 21 September 2006 3:51 PM
> To: troy@ebswift.com
> Subject: [Fwd: Issues with the Windows installer package for svn 1.4]
>
> * in pre.rtf: the link to CHANGES is the version on trunk instead of the
> 1.4 version.
Attached patch will fix the link to CHANGES.

[[[
In the Windows installer, link to the CHANGES file of 1.4.x instead of trunk

* packages/windows-innosetup/Pre.rtf: change URL to 1.4.x branch.
]]]

Lieven.