You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/09 08:36:51 UTC
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4329: Adding AutoScaling for cks
Pearl1594 commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r519632820
##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##########
@@ -261,60 +269,6 @@ private void logAndThrow(final Level logLevel, final String message, final Excep
logTransitStateAndThrow(logLevel, message, null, null, ex);
}
- private boolean isKubernetesServiceTemplateConfigured(DataCenter zone) {
- // Check Kubernetes VM template for zone
- boolean isHyperVAvailable = false;
- boolean isKVMAvailable = false;
- boolean isVMwareAvailable = false;
- boolean isXenserverAvailable = false;
- List<ClusterVO> clusters = clusterDao.listByZoneId(zone.getId());
- for (ClusterVO clusterVO : clusters) {
- if (Hypervisor.HypervisorType.Hyperv.equals(clusterVO.getHypervisorType())) {
- isHyperVAvailable = true;
- }
- if (Hypervisor.HypervisorType.KVM.equals(clusterVO.getHypervisorType())) {
- isKVMAvailable = true;
- }
- if (Hypervisor.HypervisorType.VMware.equals(clusterVO.getHypervisorType())) {
- isVMwareAvailable = true;
- }
- if (Hypervisor.HypervisorType.XenServer.equals(clusterVO.getHypervisorType())) {
- isXenserverAvailable = true;
- }
- }
- List<Pair<String, String>> templatePairs = new ArrayList<>();
- if (isHyperVAvailable) {
- templatePairs.add(new Pair<>(KubernetesClusterHyperVTemplateName.key(), KubernetesClusterHyperVTemplateName.value()));
- }
- if (isKVMAvailable) {
Review comment:
@shwstppr On an upgraded env, the existing cluster will continue to operate as is, and scaling will result in creation of a new debian-based worker node
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org