You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/21 12:35:29 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

WeiZhong94 opened a new pull request #12279:
URL: https://github.com/apache/flink/pull/12279


   ## What is the purpose of the change
   
   *This pull request fixes the OOM of the PyFlink end to end test on JDK11.*
   
   
   ## Brief change log
   
     - *Increase the total memory limit of the TaskManager of the PyFlink end to end test.*
     - *Increase the off-heap memory limit of the TaskManager of the PyFlink end to end test.*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *PyFlink end to end test*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu edited a comment on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
dianfu edited a comment on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632449422


   @WeiZhong94 Thanks for the PR. LGTM. I have verified the PR manually and the end to end test of PyFlink could pass after applying this PR with Jdk 11 (Also verified that it will fail without this PR in JDK 11).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632062307


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d4b6ac1fed94a8d757f8dc526743e9a092b77c91 (Thu May 21 12:37:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17771).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632079896


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d4b6ac1fed94a8d757f8dc526743e9a092b77c91",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2001",
       "triggerID" : "d4b6ac1fed94a8d757f8dc526743e9a092b77c91",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4b6ac1fed94a8d757f8dc526743e9a092b77c91 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2001) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632062307


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d4b6ac1fed94a8d757f8dc526743e9a092b77c91 (Fri Oct 16 10:53:38 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632079896


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d4b6ac1fed94a8d757f8dc526743e9a092b77c91",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d4b6ac1fed94a8d757f8dc526743e9a092b77c91",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4b6ac1fed94a8d757f8dc526743e9a092b77c91 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632449422


   @WeiZhong94 Thanks for the PR. LGTM. I have verified manually the PR and the end to end test of PyFlink could pass after applying this PR with Jdk 11 (Also verified that it will fail without this PR in JDK 11).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12279:
URL: https://github.com/apache/flink/pull/12279


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12279: [FLINK-17771][python][e2e] Fix the OOM of the PyFlink end to end test on JDK11.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12279:
URL: https://github.com/apache/flink/pull/12279#issuecomment-632079896


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d4b6ac1fed94a8d757f8dc526743e9a092b77c91",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2001",
       "triggerID" : "d4b6ac1fed94a8d757f8dc526743e9a092b77c91",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d4b6ac1fed94a8d757f8dc526743e9a092b77c91 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2001) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org