You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/06/18 22:29:46 UTC
commons-dbcp git commit: - [DBCP-427] Examines 'SQLException's thrown
by underlying connections or statements for fatal (disconnection) errors. -
[DBCP-507] Change default for fail-fast connections from false to true.
Repository: commons-dbcp
Updated Branches:
refs/heads/master a0c48c1e1 -> b53521ba1
- [DBCP-427] Examines 'SQLException's thrown by underlying connections
or statements for fatal (disconnection) errors.
- [DBCP-507] Change default for fail-fast connections from false to
true.
Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/b53521ba
Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/b53521ba
Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/b53521ba
Branch: refs/heads/master
Commit: b53521ba1a104bb725b63f5d11c551447b78ea59
Parents: a0c48c1
Author: Gary Gregory <ga...@gmail.com>
Authored: Mon Jun 18 16:29:42 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Mon Jun 18 16:29:42 2018 -0600
----------------------------------------------------------------------
src/changes/changes.xml | 10 ++++++++--
.../java/org/apache/commons/dbcp2/PoolableConnection.java | 2 +-
.../apache/commons/dbcp2/PoolableConnectionFactory.java | 3 ++-
.../commons/dbcp2/managed/PoolableManagedConnection.java | 2 +-
4 files changed, 12 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/b53521ba/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 1224770..4dba0b2 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -64,12 +64,18 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="update" issue="DBCP-505" due-to="Gary Gregory">
Update Java requirement from version 7 to 8.
</action>
- <action dev="ggregory" type="update" issue="DBCP-506" due-to="Gary Gregory">
+ <action dev="ggregory" type="add" issue="DBCP-506" due-to="Gary Gregory">
Support JDBC 4.2.
</action>
- <action dev="ggregory" type="update" issue="DBCP-479" due-to="Guillaume Husta, Gary Gregory">
+ <action dev="ggregory" type="add" issue="DBCP-479" due-to="Guillaume Husta, Gary Gregory">
Support default schema in configuration.
</action>
+ <action dev="ggregory" type="update" issue="DBCP-427" due-to="Vladimir Konkov, Phil Steitz, Gary Gregory">
+ Examines 'SQLException's thrown by underlying connections or statements for fatal (disconnection) errors.
+ </action>
+ <action dev="ggregory" type="update" issue="DBCP-507" due-to="Vladimir Konkov, Phil Steitz, Gary Gregory">
+ Change default for fail-fast connections from false to true.
+ </action>
</release>
<release version="2.4.0" date="2018-06-12" description="This is a minor release, including bug fixes and enhancements.">
<action dev="ggregory" type="fix" issue="DBCP-484" due-to="Emanuel Freitas">
http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/b53521ba/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
index a369f05..03432f1 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java
@@ -117,7 +117,7 @@ public class PoolableConnection extends DelegatingConnection<Connection> impleme
*/
public PoolableConnection(final Connection conn, final ObjectPool<PoolableConnection> pool,
final ObjectName jmxName) {
- this(conn, pool, jmxName, null, false);
+ this(conn, pool, jmxName, null, true);
}
@Override
http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/b53521ba/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index ad932bc..581d3ad 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -270,6 +270,7 @@ public class PoolableConnectionFactory implements PooledObjectFactory<PoolableCo
* @return true if connections created by this factory will fast fail validation.
* @see #setDisconnectionSqlCodes(Collection)
* @since 2.1
+ * @since 2.5.0 Defaults to true, previous versions defaulted to false.
*/
public boolean isFastFailValidation() {
return fastFailValidation;
@@ -484,7 +485,7 @@ public class PoolableConnectionFactory implements PooledObjectFactory<PoolableCo
private volatile int validationQueryTimeoutSeconds = -1;
private Collection<String> connectionInitSqls;
private Collection<String> disconnectionSqlCodes;
- private boolean fastFailValidation;
+ private boolean fastFailValidation = true;
private volatile ObjectPool<PoolableConnection> pool;
private Boolean defaultReadOnly;
private Boolean defaultAutoCommit;
http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/b53521ba/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java b/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java
index 7eba6e7..cee7090 100644
--- a/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java
@@ -45,7 +45,7 @@ public class PoolableManagedConnection extends PoolableConnection {
*/
public PoolableManagedConnection(final TransactionRegistry transactionRegistry, final Connection conn,
final ObjectPool<PoolableConnection> pool) {
- this(transactionRegistry, conn, pool, null, false);
+ this(transactionRegistry, conn, pool, null, true);
}
/**