You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2013/01/08 17:51:38 UTC

svn commit: r1430379 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/ImmutableACL.java

Author: mduerig
Date: Tue Jan  8 16:51:38 2013
New Revision: 1430379

URL: http://svn.apache.org/viewvc?rev=1430379&view=rev
Log:
FIXME: this implementation violates the general contract of equals: it is not symmetric.

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/ImmutableACL.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/ImmutableACL.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/ImmutableACL.java?rev=1430379&r1=1430378&r2=1430379&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/ImmutableACL.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/ImmutableACL.java Tue Jan  8 16:51:38 2013
@@ -115,6 +115,8 @@ public class ImmutableACL extends ACL {
 
     /**
      * @see Object#equals(Object)
+     * FIXME: this implementation violates the general contract of equals: it is not symmetric.
+     * While ACL.equals(ImmutableACL) might be true, ImmutableACL.equals(ACL) is always false.
      */
     @Override
     public boolean equals(Object obj) {