[GitHub] [druid] maytasm edited a comment on pull request #10740: Fix byte calculation for maxBytesInMemory to take into account of Sink/Hydrant Object overhead

[GitBox <gi...@apache.org>]

maytasm edited a comment on pull request #10740:
URL: https://github.com/apache/druid/pull/10740#issuecomment-759857109


   > this seems nice to be able to avoid out of memory exceptions 👍
   > 
   > can we add some more tests around ensuring the calculations and error conditions are well behaved in a wider variety of scenarios (lots of sinks, lots of hydrants, lots of columns, etc)?
   
   
   
   Modified the tests from
   1) one sink -> ingest -> check before persist -> ingest -> causes persist -> check
   2) multiple sink -> ingest to sink a -> check before persist -> ingest to sink b-> causes persist -> check
   to...
   1) one sink -> ingest -> check before persist -> ingest -> causes persist -> check -> ingest more -> check -> ingest more cause persist -> check
   2) multiple sink -> ingest to sink a -> check before persist -> ingest to sink b-> causes persist -> check -> ingest more -> check -> ingest more cause persist -> check
   
   now we have ingestion post the first persist and also more ingestion causing the second persist (resulting in multiple mmap hydrants in same sink)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org