You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by priyankparihar <gi...@git.apache.org> on 2016/11/24 11:51:50 UTC
[GitHub] cloudstack pull request #1776: CLOUDSTACK-9603: concurrent.snapshots.thresho...
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1776
CLOUDSTACK-9603: concurrent.snapshots.threshold.perhost does not vali\u2026
concurrent.snapshots.threshold.perhost does not validate value given
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1776
----
commit 141926b1439c2fe99621c9c56114e948066f17c3
Author: Priyank Parihar <pr...@accelerite.com>
Date: 2016-09-06T17:41:06Z
CLOUDSTACK-9603: concurrent.snapshots.threshold.perhost does not validate value given.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: concurrent.snapshots.threshold.perh...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@priyankparihar could you please provide further explanation as to how this fix addresses the issue of `concurrent.snapshots.threshold.perhost` not being validated?
Also, is there an existing Marvin test case and/or unit test that verifies this fix? If not, could you please add one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@borisstoyanov Can you please trigger tests for this PR? Tests could be over any hypervisor/simulator as the fix is pretty generic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by sowmyakrishn <gi...@git.apache.org>.
Github user sowmyakrishn commented on the issue:
https://github.com/apache/cloudstack/pull/1776
Reviewed test code. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: 'concurrent.snapshots.threshold.perhost' parameter s...
Posted by priyankparihar <gi...@git.apache.org>.
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1776
Thanks @rajesh-battala and @jburwell
>You can modify the description and which can reflect the fix or the check you are doing in the code.
Modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1776
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: concurrent.snapshots.threshold.perh...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@priyankparihar I have gone through the bug and the bug description is causing ambiguity that's the @jburwell had made above comment.
You can modify the description and which can reflect the fix or the check you are doing in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1776
<b>Trillian test result (tid-930)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35187 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1776-t930-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 3 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 182.51 | test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 335.45 | test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py
test_01_vpc_site2site_vpn | Success | 170.49 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 56.06 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 220.40 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 266.93 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 493.22 | test_vpc_router_nics.py
test_04_rvpc_network_garbage_collector_nics | Success | 1426.31 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 543.96 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 744.19 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1305.78 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.79 | test_volumes.py
test_08_resize_volume | Success | 156.36 | test_volumes.py
test_07_resize_fail | Success | 161.45 | test_volumes.py
test_06_download_detached_volume | Success | 157.86 | test_volumes.py
test_05_detach_volume | Success | 150.79 | test_volumes.py
test_04_delete_attached_volume | Success | 151.18 | test_volumes.py
test_03_download_attached_volume | Success | 156.31 | test_volumes.py
test_02_attach_volume | Success | 84.09 | test_volumes.py
test_01_create_volume | Success | 714.36 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.73 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 133.62 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 272.75 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 31.55 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.85 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.85 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.84 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 40.49 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 45.44 | test_templates.py
test_10_destroy_cpvm | Success | 161.74 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.71 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.57 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.63 | test_ssvm.py
test_06_stop_cpvm | Success | 131.74 | test_ssvm.py
test_05_stop_ssvm | Success | 133.77 | test_ssvm.py
test_04_cpvm_internals | Success | 1.21 | test_ssvm.py
test_03_ssvm_internals | Success | 3.52 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.09 | test_snapshots.py
test_04_change_offering_small | Success | 239.62 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.30 | test_routers.py
test_08_start_router | Success | 25.26 | test_routers.py
test_07_stop_router | Success | 10.15 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.57 | test_routers.py
test_03_restart_network_cleanup | Success | 50.47 | test_routers.py
test_02_router_internal_adv | Success | 0.85 | test_routers.py
test_01_router_internal_basic | Success | 0.46 | test_routers.py
test_router_dns_guestipquery | Success | 76.80 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.07 | test_router_dns.py
test_router_dhcphosts | Success | 293.65 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.68 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.08 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 130.95 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 5.21 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.43 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 474.88 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 344.77 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 77.04 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.76 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.20 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.44 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.49 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.13 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.68 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 18.85 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.25 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 10.37 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.34 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.30 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.30 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.40 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 87.60 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.15 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.07 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.42 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.32 | test_non_contigiousvlan.py
test_01_nic | Success | 424.32 | test_nic.py
test_releaseIP | Success | 142.23 | test_network.py
test_reboot_router | Success | 403.44 | test_network.py
test_public_ip_user_account | Success | 10.61 | test_network.py
test_public_ip_admin_account | Success | 40.28 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.80 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.76 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 121.04 | test_network.py
test_delete_account | Success | 257.59 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.67 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.74 | test_network.py
test_nic_secondaryip_add_remove | Success | 227.62 | test_multipleips_per_nic.py
login_test_saml_user | Success | 19.36 | test_login.py
test_assign_and_removal_lb | Success | 133.21 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.00 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 207.49 | test_loadbalance.py
test_03_list_snapshots | Success | 0.09 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.07 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.17 | test_iso.py
test_03_delete_iso | Success | 95.15 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 21.00 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 208.62 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 127.67 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 465.50 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 415.13 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.39 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.15 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.98 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.84 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.87 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.99 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 6.11 | test_dynamicroles.py
test_role_lifecycle_update | Success | 10.96 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.88 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 10.91 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.88 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.85 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.14 | test_dynamicroles.py
test_role_account_acls | Success | 8.12 | test_dynamicroles.py
test_default_role_deletion | Success | 5.95 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.08 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.61 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 20.56 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 95.89 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 5.38 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 55.76 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.97 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.97 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 217.45 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 212.65 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 76.00 | test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1776
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1776
Thanks for this fix @priyankparihar , if it addresses only the input validation should be pretty easy to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---