You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/05 21:57:58 UTC

[GitHub] [incubator-mxnet] szha commented on a change in pull request #20127: [PIP] set osx deploy target for v1.x wheels

szha commented on a change in pull request #20127:
URL: https://github.com/apache/incubator-mxnet/pull/20127#discussion_r607358142



##########
File path: tools/staticbuild/build_lib_cmake.sh
##########
@@ -30,7 +30,12 @@ git submodule update --init --recursive || true
 
 # Build libmxnet.so
 rm -rf build; mkdir build; cd build
-cmake -GNinja -C $cmake_config -DCMAKE_PREFIX_PATH=${DEPS_PATH} -DCMAKE_FIND_ROOT_PATH=${DEPS_PATH} ..
+cmake \
+    -GNinja \
+    -C $cmake_config \
+    -DCMAKE_PREFIX_PATH=${DEPS_PATH} \
+    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \

Review comment:
       should have no harm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org