You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/12/14 11:51:30 UTC
[PR] CAMEL-20225: move date-related information to a separate abstraction [camel]
orpiske opened a new pull request, #12450:
URL: https://github.com/apache/camel/pull/12450
This is the first part of the task. At this moment, it still relies on System.currentTimeMillis to compute the elapsed time in order to retain the current behavior and ensure the refactoring is solid. A subsequent PR will then add a new field to track the duration separatelly from the real clock part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20225: move time-related information to a separate abstraction [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #12450:
URL: https://github.com/apache/camel/pull/12450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20225: move date-related information to a separate abstraction [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12450:
URL: https://github.com/apache/camel/pull/12450#issuecomment-1855709765
Previous tests were all good, but I'm waiting for one last test on my CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20225: move time-related information to a separate abstraction [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12450:
URL: https://github.com/apache/camel/pull/12450#issuecomment-1855740923
The `Clock` API seems generic so it may not be tied only to Exchange - could be that its API doc should be made more generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20225: move date-related information to a separate abstraction [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12450:
URL: https://github.com/apache/camel/pull/12450#issuecomment-1855707039
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20225: move time-related information to a separate abstraction [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12450:
URL: https://github.com/apache/camel/pull/12450#issuecomment-1855798103
> The `Clock` API seems generic so it may not be tied only to Exchange - could be that its API doc should be made more generic.
Indeed! I'm starting small, but I think it could be used it on `Message` and a few other places in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org