You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/29 19:06:13 UTC

[GitHub] [beam] lukecwik commented on pull request #15553: [BEAM-12922] Update windmill state map to resolve computeIfAbsent methods immediately

lukecwik commented on pull request #15553:
URL: https://github.com/apache/beam/pull/15553#issuecomment-930462776


   This looks great.
   
   In a follow-up PR we should add a MapState validates runner test that uses TestStream + putIfAbsent/computeIfAbsent with no reads in the first bundle and in the second bundle we check the values were set correctly. This allows us to make sure that all implementations (e.g. SamzaMapStateImpl, FlinkMapState, ...) honor this going forward instead of just testing the specific implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org