You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/18 08:16:11 UTC
[GitHub] [rocketmq] Git-Yang opened a new pull request #3506: [ISSUE #3505] Fix parameter conflict
Git-Yang opened a new pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506
## What is the purpose of the change
https://github.com/apache/rocketmq/issues/3505
## Brief changelog
- Merged the command code in the pop_consumer branch.
- Fix parameter conflict
- Add clientRebalanceEnable in benchmark
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506#issuecomment-972677897
[](https://coveralls.io/builds/44363318)
Coverage decreased (-0.05%) to 53.43% when pulling **9ef5a9dc515dc8d6965da13dde996ae6ebb56218 on Git-Yang:5.0.0-alpha-dev** into **4506f34e24714ec4d6ac37babd8f096632fd6b1c on apache:5.0.0-alpha**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506#issuecomment-972677897
[](https://coveralls.io/builds/44373930)
Coverage decreased (-0.09%) to 53.391% when pulling **a9d5138fae4b1f2156594e32d7ef1c604a6cd6f9 on Git-Yang:5.0.0-alpha-dev** into **4506f34e24714ec4d6ac37babd8f096632fd6b1c on apache:5.0.0-alpha**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Git-Yang merged pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
Git-Yang merged pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506#issuecomment-972677897
[](https://coveralls.io/builds/44380933)
Coverage decreased (-0.07%) to 53.408% when pulling **957935c2f24fb61062f873236bb264c528cf33c5 on Git-Yang:5.0.0-alpha-dev** into **4506f34e24714ec4d6ac37babd8f096632fd6b1c on apache:5.0.0-alpha**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506#issuecomment-972974745
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3506](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9d5138) into [5.0.0-alpha](https://codecov.io/gh/apache/rocketmq/commit/0f5a0a1e64234e1fbd6c50277ef31831d9003767?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f5a0a1) will **increase** coverage by `0.14%`.
> The diff coverage is `72.11%`.
[](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 5.0.0-alpha #3506 +/- ##
=================================================
+ Coverage 46.85% 47.00% +0.14%
- Complexity 4981 5013 +32
=================================================
Files 612 613 +1
Lines 42012 42166 +154
Branches 5739 5760 +21
=================================================
+ Hits 19686 19821 +135
- Misses 19680 19693 +13
- Partials 2646 2652 +6
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/rocketmq/client/consumer/MessageSelector.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvTWVzc2FnZVNlbGVjdG9yLmphdmE=) | `0.00% <ø> (ø)` | |
| [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `25.33% <0.00%> (+0.10%)` | :arrow_up: |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `50.86% <0.00%> (+0.27%)` | :arrow_up: |
| [.../apache/rocketmq/remoting/common/RemotingUtil.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL2NvbW1vbi9SZW1vdGluZ1V0aWwuamF2YQ==) | `12.50% <0.00%> (-0.13%)` | :arrow_down: |
| [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `39.85% <45.45%> (-0.05%)` | :arrow_down: |
| [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `49.17% <50.00%> (+0.68%)` | :arrow_up: |
| [.../main/java/org/apache/rocketmq/common/UtilAll.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vVXRpbEFsbC5qYXZh) | `40.76% <50.00%> (-0.45%)` | :arrow_down: |
| [...va/org/apache/rocketmq/store/GetMessageResult.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0dldE1lc3NhZ2VSZXN1bHQuamF2YQ==) | `71.15% <50.00%> (-7.57%)` | :arrow_down: |
| [...ocketmq/store/schedule/ScheduleMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3NjaGVkdWxlL1NjaGVkdWxlTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.72% <58.97%> (-1.01%)` | :arrow_down: |
| [.../java/org/apache/rocketmq/acl/common/AclUtils.java](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL0FjbFV0aWxzLmphdmE=) | `77.01% <59.09%> (-2.84%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/rocketmq/pull/3506/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4506f34...a9d5138](https://codecov.io/gh/apache/rocketmq/pull/3506?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Git-Yang commented on a change in pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
Git-Yang commented on a change in pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506#discussion_r752820882
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/consumer/SetConsumeModeSubCommand.java
##########
@@ -64,7 +64,7 @@ public Options buildCommandlineOptions(Options options) {
opt.setRequired(true);
options.addOption(opt);
- opt = new Option("n", "popShareQueueNum", true, "num fo queue which share in pop mode");
+ opt = new Option("q", "popShareQueueNum", true, "num of queue which share in pop mode");
Review comment:
This option is already used by namesrv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Jason918 commented on a change in pull request #3506: [ISSUE #3505] Fix parameter conflict
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #3506:
URL: https://github.com/apache/rocketmq/pull/3506#discussion_r752814170
##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/consumer/SetConsumeModeSubCommand.java
##########
@@ -64,7 +64,7 @@ public Options buildCommandlineOptions(Options options) {
opt.setRequired(true);
options.addOption(opt);
- opt = new Option("n", "popShareQueueNum", true, "num fo queue which share in pop mode");
+ opt = new Option("q", "popShareQueueNum", true, "num of queue which share in pop mode");
Review comment:
Why do we need change this? It seems would cause some compatibility issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org