You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/15 11:36:03 UTC
[GitHub] [pulsar] aahmed-se opened a new pull request #7542: Add advertisedAddress config field to ProxyConfiguration
aahmed-se opened a new pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542
Proxy can have it's advertisedAddress configured a parameter like broker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7542: Add advertisedAddress config field to ProxyConfiguration
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542#issuecomment-659190469
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7542: Add advertisedAddress config field to ProxyConfiguration
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542#issuecomment-717808365
Move this change to 2.6.2, because #8067 depends on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #7542: Add advertisedAddress config field to ProxyConfiguration
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542#issuecomment-659082217
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7542: Add advertisedAddress config field to ProxyConfiguration
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542#discussion_r455173056
##########
File path: pulsar-proxy/pom.xml
##########
@@ -165,5 +165,20 @@
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
</dependency>
+
+ <dependency>
Review comment:
Are these new deps needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #7542: Add advertisedAddress config field to ProxyConfiguration
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542#discussion_r455335500
##########
File path: pulsar-proxy/pom.xml
##########
@@ -165,5 +165,20 @@
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
</dependency>
+
+ <dependency>
Review comment:
removed it they are required for running it in the ide only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se merged pull request #7542: Add advertisedAddress config field to ProxyConfiguration
Posted by GitBox <gi...@apache.org>.
aahmed-se merged pull request #7542:
URL: https://github.com/apache/pulsar/pull/7542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org