You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/09/06 04:30:05 UTC

[GitHub] [zeppelin] proceane opened a new pull request, #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

proceane opened a new pull request, #4458:
URL: https://github.com/apache/zeppelin/pull/4458

   ### What is this PR for?
   This is the task of adding a spring boot dependency to switch JaxRs and Jersey to Spring.
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [x] - Add `spring-boot-dependencies` in zeppelin-server
   * [x] - Upgrade jersey, jetty version
   - Because of conflicts with jersey and jetty versions that exist inside spring-boot-dependencies
   - jersey: `2.35`, jetty: `9.4.48.v20220622`
   * [x] - Add `jackson-core`, `jackson-annotations`, `jackson-module-jaxb-annotations` dependency
   - Currently, the jackson version set in zeppein-server is `2.12.6.1`, but some of the jackson dependencies do not exist this version.
   - jackson-core, jackson-annotations: `2.13.3`
   - jackson-module-jaxb-annotations: `2.12.2`(Using this version due to version conflict in zeppelin-distribution)
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5812
   
   ### How should this be tested?
   CI
   
   ### Questions:
   * Does the licenses files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] zjffdu commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

Posted by GitBox <gi...@apache.org>.
zjffdu commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1237807031

   @proceane CI is failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1237937747

   @proceane You will find detailed information on why CI fails in logs. E.g.
   
   ```
   Dependency convergence error for commons-net:commons-net:3.8.0 paths to dependency are:
   +-org.apache.zeppelin:zeppelin-server:0.11.0-SNAPSHOT
     +-org.seleniumhq.selenium:selenium-java:2.48.2
       +-org.seleniumhq.selenium:selenium-htmlunit-driver:2.48.2
         +-net.sourceforge.htmlunit:htmlunit:2.60.0
           +-commons-net:commons-net:3.8.0
   and
   +-org.apache.zeppelin:zeppelin-server:0.11.0-SNAPSHOT
     +-org.apache.hadoop:hadoop-common:2.7.7
       +-commons-net:commons-net:3.1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433126434

   Long time no see. I think you'd better rebase this branch, not mering current master :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] proceane commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

Posted by "proceane (via GitHub)" <gi...@apache.org>.
proceane commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433197598

   oh....... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4458:
URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1237901721

   @proceane You'd better change the status of this PR from `open` to `draft`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org