You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/10/05 16:15:36 UTC
[GitHub] cordova-windows pull request #199: CB-11825 Windows dll file won't be copied...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/199
CB-11825 Windows dll file won't be copied as resource while adding cu\u2026
\u2026stom plugin to a UWP project
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Changing Package action from Content to None because Content does not work for Mobile - dlls were not being packaged into appx
### What testing has been done on this change?
Manual and auto tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-windows CB-11825
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #199
----
commit 8349e0c069dd8847237fbd27effb273d86f31504
Author: daserge <v-...@microsoft.com>
Date: 2016-10-05T16:01:26Z
CB-11825 Windows dll file won't be copied as resource while adding custom plugin to a UWP project
Changing Package action from Content to None because Content does not work for Mobile - dlls were not being packaged into appx
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #199: CB-11825 Windows dll file won't be copied as res...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/199
## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/199?src=pr) is 74.34% (diff: 100%)
> Merging [#199](https://codecov.io/gh/apache/cordova-windows/pull/199?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage
```diff
@@ master #199 diff @@
==========================================
Files 14 14
Lines 1949 1949
Methods 366 366
Messages 0 0
Branches 392 392
==========================================
Hits 1449 1449
Misses 500 500
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [bf505cc...8349e0c](https://codecov.io/gh/apache/cordova-windows/compare/bf505cc69c13d16b4d3c32d1bef53367f16b6230...8349e0c069dd8847237fbd27effb273d86f31504?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #199: CB-11825 Windows dll file won't be copied...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org