You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/02 05:56:10 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new issue #15748: [OpenForce 2022] support parsing Postgre sql `DROP MATERIALIZED VIEW`
tuichenchuxin opened a new issue #15748:
URL: https://github.com/apache/shardingsphere/issues/15748
Hi community,
This issue is for [OpenForce 2022](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
## Background
ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). At present, this parser engine can handle SQLs for `MySQL`, `PostgreSQL`, `SQLServer`, `openGauss` and `Oracle`, which means we have to understand different database dialect SQLs.
More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
## Task
This issue is to solve some of the unsupported postgres sqls in [this file](https://github.com/apache/shardingsphere/blob/master/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/unsupported/unsupported.xml) .
- [ ] DROP MATERIALIZED VIEW
You can learn more details about this SQL [here](https://www.postgresql.org/docs/current/sql-commands.html).
- You may need to try to get why it's not supported.(antlr4 grammar? or not implement visit method) You can use [antlr4 plugins](https://plugins.jetbrains.com/plugin/7358-antlr-v4) to help you to analyze. You may need to visit [an official doc](https://www.postgresql.org/docs/current/sql-commands.html) to check the grammar.
- After you fix it, remember to add a new corresponding SQL case in [SQL Cases](https://github.com/apache/shardingsphere/tree/master/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported) and expected parsed result in [Expected Statment XML](https://github.com/apache/shardingsphere/tree/master/shardingsphere-test/shardingsphere-parser-test/src/main/resources/case).
- Run [SQLParserParameterizedTest](https://github.com/apache/shardingsphere/blob/master/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/SQLParserParameterizedTest.java) and [UnsupportedSQLParserParameterizedTest](https://github.com/apache/shardingsphere/blob/master/shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/UnsupportedSQLParserParameterizedTest.java) to make sure no exceptions.
Notice, these issues can be a good example.
[support alter foreign table for pg/og ](https://github.com/apache/shardingsphere/pull/14944)
[support alter materialized view for pg/og.](https://github.com/apache/shardingsphere/pull/15331)
## Relevant Skills
1. Master JAVA language
2. Have a basic understanding of Antlr g4 file
3. Be familiar with Postgres SQLs
## Targets files
1. Postgres SQLs g4 file: https://github.com/apache/shardingsphere/blob/master/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatement.g4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Trydamere commented on issue #15748: [OpenForce 2022] support parsing Postgre sql `DROP MATERIALIZED VIEW`
Posted by GitBox <gi...@apache.org>.
Trydamere commented on issue #15748:
URL: https://github.com/apache/shardingsphere/issues/15748#issuecomment-1074702686
Hi, @tuichenchuxin I would like to work on this issue. Could you assgin it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w closed issue #15748: [OpenForce 2022] support parsing Postgre sql `DROP MATERIALIZED VIEW`
Posted by GitBox <gi...@apache.org>.
Liangda-w closed issue #15748:
URL: https://github.com/apache/shardingsphere/issues/15748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org