You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/14 06:16:22 UTC
Review Request 26677: Sqoop2: Prefix mapreduce classes with MR ( no
functionality change)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26677/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Prefix mapreduce classes with MR ( no functionality change)
- another rename left out from the repository upgrade.
- as usual clean up unused imports.
Diffs
-----
common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 3272b56
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478
execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60
execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.java 4c2e206
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopProgressRunnable.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositoryUpgrade.java PRE-CREATION
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef
Diff: https://reviews.apache.org/r/26677/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 26677: Sqoop2: Prefix mapreduce classes with MR (
no functionality change)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26677/#review56574
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Oct. 14, 2014, 2:36 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26677/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 2:36 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Prefix mapreduce classes with MR ( no functionality change)
> - another rename left out from the repository upgrade.
> - as usual clean up unused imports.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 3272b56
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478
> execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.java 4c2e206
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopProgressRunnable.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147
> execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef
>
> Diff: https://reviews.apache.org/r/26677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26677: Sqoop2: Prefix mapreduce classes with MR (
no functionality change)
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26677/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 7:36 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Prefix mapreduce classes with MR ( no functionality change)
- another rename left out from the repository upgrade.
- as usual clean up unused imports.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 3272b56
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478
execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60
execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.java 4c2e206
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopProgressRunnable.java PRE-CREATION
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef
Diff: https://reviews.apache.org/r/26677/diff/
Testing
-------
Thanks,
Veena Basavaraj
Re: Review Request 26677: Sqoop2: Prefix mapreduce classes with MR (
no functionality change)
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 14, 2014, 5:39 a.m., Jarek Cecho wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositoryUpgrade.java, line 29
> > <https://reviews.apache.org/r/26677/diff/1/?file=720313#file720313line29>
> >
> > This file doesn't seem to be relevant for this patch?
see the latest patch
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26677/#review56511
-----------------------------------------------------------
On Oct. 14, 2014, 7:36 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26677/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 7:36 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Prefix mapreduce classes with MR ( no functionality change)
> - another rename left out from the repository upgrade.
> - as usual clean up unused imports.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 3272b56
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478
> execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.java 4c2e206
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopProgressRunnable.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147
> execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef
>
> Diff: https://reviews.apache.org/r/26677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 26677: Sqoop2: Prefix mapreduce classes with MR (
no functionality change)
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26677/#review56511
-----------------------------------------------------------
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositoryUpgrade.java
<https://reviews.apache.org/r/26677/#comment96878>
This file doesn't seem to be relevant for this patch?
- Jarek Cecho
On Oct. 14, 2014, 4:16 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26677/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 4:16 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Prefix mapreduce classes with MR ( no functionality change)
> - another rename left out from the repository upgrade.
> - as usual clean up unused imports.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 3272b56
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478
> execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1
> execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ProgressRunnable.java 4c2e206
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopProgressRunnable.java PRE-CREATION
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147
> execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION
> execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java d4c4009
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositoryUpgrade.java PRE-CREATION
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef
>
> Diff: https://reviews.apache.org/r/26677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Veena Basavaraj
>
>