[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #13281: Remove alert when delete workflow instance

[GitBox <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #13281:
URL: https://github.com/apache/dolphinscheduler/pull/13281#discussion_r1057215351


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceController.java:
##########
@@ -394,15 +394,11 @@
~            String[] processInstanceIdArray = processInstanceIds.split(Constants.COMMA);
~
             for (String strProcessInstanceId : processInstanceIdArray) {
                 int processInstanceId = Integer.parseInt(strProcessInstanceId);
                 try {
-                    Map<String, Object> deleteResult =
-                            processInstanceService.deleteProcessInstanceById(loginUser, projectCode, processInstanceId);
-                    if (!Status.SUCCESS.equals(deleteResult.get(Constants.STATUS))) {
-                        deleteFailedIdList.add((String) deleteResult.get(Constants.MSG));
-                        logger.error((String) deleteResult.get(Constants.MSG));
-                    }
+                    processInstanceService.deleteProcessInstanceById(loginUser, projectCode, processInstanceId);
                 } catch (Exception e) {
+                    logger.error("Delete workflow instance: {} error", strProcessInstanceId, e);

Review Comment:
   ## Log Injection
   
   This log entry depends on a [user-provided value](1).
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2439)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org