[jira] [Commented] (CAMEL-11139) ClassNotFoundException may silently be ignored in InProducer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965806#comment-15965806 ] 

ASF GitHub Bot commented on CAMEL-11139:
----------------------------------------

GitHub user tdiesler opened a pull request:

    https://github.com/apache/camel/pull/1618

    [CAMEL-11139] ClassNotFoundException may silently be ignored in InPro…

    …ducer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tdiesler/camel CAMEL-11139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1618.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1618
    
----
commit e321440dd1b68c93293958343cbcce722c6b0943
Author: Thomas Diesler <th...@jboss.com>
Date:   2017-04-12T12:43:39Z

    [CAMEL-11139] ClassNotFoundException may silently be ignored in InProducer

----


> ClassNotFoundException may silently be ignored in InProducer
> ------------------------------------------------------------
>
>                 Key: CAMEL-11139
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11139
>             Project: Camel
>          Issue Type: Bug
>    Affects Versions: 2.18.3
>            Reporter: Thomas Diesler
>            Assignee: Thomas Diesler
>             Fix For: 2.18.4, 2.19.0
>
>
> [ProducerCache.doInProducer()|https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/impl/ProducerCache.java#L348] may be called with null exchange. 
> The javadoc says
> {code}
>     /**
>      * Sends an exchange to an endpoint using a supplied callback, using the synchronous processing.
>      * <p/>
>      * If an exception was thrown during processing, it would be set on the given Exchange
>      *
>      * @param endpoint  the endpoint to send the exchange to
>      * @param exchange  the exchange, can be <tt>null</tt> if so then create a new exchange from the producer
>      * @param pattern   the exchange pattern, can be <tt>null</tt>
>      * @param callback  the callback
>      * @return the response from the callback
>      * @see #doInAsyncProducer(org.apache.camel.Endpoint, org.apache.camel.Exchange, org.apache.camel.ExchangePattern, org.apache.camel.AsyncCallback, org.apache.camel.AsyncProducerCallback)
>      */
>     public <T> T doInProducer(Endpoint endpoint, Exchange exchange, ExchangePattern pattern, ProducerCallback<T> callback) {
> {code}
> The exchange is however never created, which may result in a null return from ProducerTemplate and a possible exception silently being ignored.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)