[GitHub] [beam] Sanil15 commented on a diff in pull request #26437: #26456 : Basic Tranform metric like throughput, watermark progress & latency support for non data shuffle transforms for Samza Runner

["Sanil15 (via GitHub)" <gi...@apache.org>]

Sanil15 commented on code in PR #26437:
URL: https://github.com/apache/beam/pull/26437#discussion_r1181761438


##########
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/GroupByKeyTranslator.java:
##########
@@ -104,7 +104,7 @@ private static <K, InputT, OutputT> void doTranslate(
             outputTag,
             input.isBounded());
 
-    ctx.registerMessageStream(output, outputStream);
+    ctx.registerMessageStream(output, outputStream, false);

Review Comment:
   GBK will be a different PR, remember the watermark broadcast issue we discussed - we will do calculation for GBK + Shuffle Latency per windowId



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org