You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2010/12/27 10:24:13 UTC
Re: svn commit: r1053027 - /wicket/trunk/pom.xml
Hi Juergen,
What was the problem before this change ?
The build was OK here and at Hudson (excluding the problem with
DatePickerTest).
With this change 'wicket' module (three in one) is not build for none of the
profiles. I agree it is not needed for profile 'all' (active by default) but
'wicket' module should be part of 'release' and 'apache-nexus-deploy'
profiles
martin-g
On Mon, Dec 27, 2010 at 10:09 AM, <jd...@apache.org> wrote:
> Author: jdonnerstag
> Date: Mon Dec 27 09:09:16 2010
> New Revision: 1053027
>
> URL: http://svn.apache.org/viewvc?rev=1053027&view=rev
> Log:
> wicket-core related change to make maven work
>
> Modified:
> wicket/trunk/pom.xml
>
> Modified: wicket/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=1053027&r1=1053026&r2=1053027&view=diff
>
> ==============================================================================
> --- wicket/trunk/pom.xml (original)
> +++ wicket/trunk/pom.xml Mon Dec 27 09:09:16 2010
> @@ -48,7 +48,7 @@
> the parent.
> -->
> <modules>
> - <module>wicket</module>
> + <module>wicket-core</module>
> <module>wicket-util</module>
> <module>wicket-datetime</module>
> <module>wicket-request</module>
> @@ -63,7 +63,6 @@
> <module>wicket-objectssizeof-agent</module>
> <module>wicket-examples</module>
> <module>archetypes/quickstart</module>
> - <module>wicket-core</module>
> </modules>
> <build>
> <plugins>
> @@ -124,7 +123,7 @@
> <activeByDefault>false</activeByDefault>
> </activation>
> <modules>
> - <module>wicket</module>
> + <module>wicket-core</module>
> <module>wicket-util</module>
> <module>wicket-datetime</module>
> <module>wicket-request</module>
> @@ -139,7 +138,6 @@
> <module>wicket-objectssizeof-agent</module>
> <module>wicket-examples</module>
> <module>archetypes/quickstart</module>
> - <module>wicket-core</module>
> </modules>
> <build>
> <plugins>
> @@ -183,7 +181,7 @@
> <activeByDefault>true</activeByDefault>
> </activation>
> <modules>
> - <module>wicket</module>
> + <module>wicket-core</module>
> <module>wicket-util</module>
> <module>wicket-datetime</module>
> <module>wicket-request</module>
> @@ -199,7 +197,6 @@
> <module>wicket-examples</module>
> <module>archetypes/quickstart</module>
> <module>testing/wicket-threadtest</module>
> - <module>wicket-core</module>
> </modules>
>
> <distributionManagement>
>
>
>
Re: svn commit: r1053027 - /wicket/trunk/pom.xml
Posted by Juergen Donnerstag <ju...@gmail.com>.
my mistake. Don't know what happend, but it's working now (with your
original version). I'll revert.
Juergen
On Mon, Dec 27, 2010 at 10:38 AM, Juergen Donnerstag
<ju...@gmail.com> wrote:
> I'll try it again
>
> -Juergen
>
> On Mon, Dec 27, 2010 at 10:36 AM, Martin Grigorov <mg...@apache.org> wrote:
>> weird...
>> I just reverted your change locally and both Maven 2.2.1 and Maven 3.0.1
>> work without problems
>>
>> On Mon, Dec 27, 2010 at 10:27 AM, Juergen Donnerstag <
>> juergen.donnerstag@gmail.com> wrote:
>>
>>> maven 3.x complained about an error in pom.xml (did a clean checkout).
>>> maven did nothing. Not even clean or eclipse:eclipse did work.
>>>
>>> Juergen
>>>
>>> On Mon, Dec 27, 2010 at 10:24 AM, Martin Grigorov <mg...@apache.org>
>>> wrote:
>>> > Hi Juergen,
>>> >
>>> > What was the problem before this change ?
>>> >
>>> > The build was OK here and at Hudson (excluding the problem with
>>> > DatePickerTest).
>>> >
>>> > With this change 'wicket' module (three in one) is not build for none of
>>> the
>>> > profiles. I agree it is not needed for profile 'all' (active by default)
>>> but
>>> > 'wicket' module should be part of 'release' and 'apache-nexus-deploy'
>>> > profiles
>>> >
>>> > martin-g
>>> >
>>> > On Mon, Dec 27, 2010 at 10:09 AM, <jd...@apache.org> wrote:
>>> >
>>> >> Author: jdonnerstag
>>> >> Date: Mon Dec 27 09:09:16 2010
>>> >> New Revision: 1053027
>>> >>
>>> >> URL: http://svn.apache.org/viewvc?rev=1053027&view=rev
>>> >> Log:
>>> >> wicket-core related change to make maven work
>>> >>
>>> >> Modified:
>>> >> wicket/trunk/pom.xml
>>> >>
>>> >> Modified: wicket/trunk/pom.xml
>>> >> URL:
>>> >>
>>> http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=1053027&r1=1053026&r2=1053027&view=diff
>>> >>
>>> >>
>>> ==============================================================================
>>> >> --- wicket/trunk/pom.xml (original)
>>> >> +++ wicket/trunk/pom.xml Mon Dec 27 09:09:16 2010
>>> >> @@ -48,7 +48,7 @@
>>> >> the parent.
>>> >> -->
>>> >> <modules>
>>> >> - <module>wicket</module>
>>> >> + <module>wicket-core</module>
>>> >> <module>wicket-util</module>
>>> >> <module>wicket-datetime</module>
>>> >> <module>wicket-request</module>
>>> >> @@ -63,7 +63,6 @@
>>> >>
>>> <module>wicket-objectssizeof-agent</module>
>>> >> <module>wicket-examples</module>
>>> >> <module>archetypes/quickstart</module>
>>> >> - <module>wicket-core</module>
>>> >> </modules>
>>> >> <build>
>>> >> <plugins>
>>> >> @@ -124,7 +123,7 @@
>>> >> <activeByDefault>false</activeByDefault>
>>> >> </activation>
>>> >> <modules>
>>> >> - <module>wicket</module>
>>> >> + <module>wicket-core</module>
>>> >> <module>wicket-util</module>
>>> >> <module>wicket-datetime</module>
>>> >> <module>wicket-request</module>
>>> >> @@ -139,7 +138,6 @@
>>> >>
>>> <module>wicket-objectssizeof-agent</module>
>>> >> <module>wicket-examples</module>
>>> >> <module>archetypes/quickstart</module>
>>> >> - <module>wicket-core</module>
>>> >> </modules>
>>> >> <build>
>>> >> <plugins>
>>> >> @@ -183,7 +181,7 @@
>>> >> <activeByDefault>true</activeByDefault>
>>> >> </activation>
>>> >> <modules>
>>> >> - <module>wicket</module>
>>> >> + <module>wicket-core</module>
>>> >> <module>wicket-util</module>
>>> >> <module>wicket-datetime</module>
>>> >> <module>wicket-request</module>
>>> >> @@ -199,7 +197,6 @@
>>> >> <module>wicket-examples</module>
>>> >> <module>archetypes/quickstart</module>
>>> >>
>>> <module>testing/wicket-threadtest</module>
>>> >> - <module>wicket-core</module>
>>> >> </modules>
>>> >>
>>> >> <distributionManagement>
>>> >>
>>> >>
>>> >>
>>> >
>>>
>>
>
Re: svn commit: r1053027 - /wicket/trunk/pom.xml
Posted by Juergen Donnerstag <ju...@gmail.com>.
I'll try it again
-Juergen
On Mon, Dec 27, 2010 at 10:36 AM, Martin Grigorov <mg...@apache.org> wrote:
> weird...
> I just reverted your change locally and both Maven 2.2.1 and Maven 3.0.1
> work without problems
>
> On Mon, Dec 27, 2010 at 10:27 AM, Juergen Donnerstag <
> juergen.donnerstag@gmail.com> wrote:
>
>> maven 3.x complained about an error in pom.xml (did a clean checkout).
>> maven did nothing. Not even clean or eclipse:eclipse did work.
>>
>> Juergen
>>
>> On Mon, Dec 27, 2010 at 10:24 AM, Martin Grigorov <mg...@apache.org>
>> wrote:
>> > Hi Juergen,
>> >
>> > What was the problem before this change ?
>> >
>> > The build was OK here and at Hudson (excluding the problem with
>> > DatePickerTest).
>> >
>> > With this change 'wicket' module (three in one) is not build for none of
>> the
>> > profiles. I agree it is not needed for profile 'all' (active by default)
>> but
>> > 'wicket' module should be part of 'release' and 'apache-nexus-deploy'
>> > profiles
>> >
>> > martin-g
>> >
>> > On Mon, Dec 27, 2010 at 10:09 AM, <jd...@apache.org> wrote:
>> >
>> >> Author: jdonnerstag
>> >> Date: Mon Dec 27 09:09:16 2010
>> >> New Revision: 1053027
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=1053027&view=rev
>> >> Log:
>> >> wicket-core related change to make maven work
>> >>
>> >> Modified:
>> >> wicket/trunk/pom.xml
>> >>
>> >> Modified: wicket/trunk/pom.xml
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=1053027&r1=1053026&r2=1053027&view=diff
>> >>
>> >>
>> ==============================================================================
>> >> --- wicket/trunk/pom.xml (original)
>> >> +++ wicket/trunk/pom.xml Mon Dec 27 09:09:16 2010
>> >> @@ -48,7 +48,7 @@
>> >> the parent.
>> >> -->
>> >> <modules>
>> >> - <module>wicket</module>
>> >> + <module>wicket-core</module>
>> >> <module>wicket-util</module>
>> >> <module>wicket-datetime</module>
>> >> <module>wicket-request</module>
>> >> @@ -63,7 +63,6 @@
>> >>
>> <module>wicket-objectssizeof-agent</module>
>> >> <module>wicket-examples</module>
>> >> <module>archetypes/quickstart</module>
>> >> - <module>wicket-core</module>
>> >> </modules>
>> >> <build>
>> >> <plugins>
>> >> @@ -124,7 +123,7 @@
>> >> <activeByDefault>false</activeByDefault>
>> >> </activation>
>> >> <modules>
>> >> - <module>wicket</module>
>> >> + <module>wicket-core</module>
>> >> <module>wicket-util</module>
>> >> <module>wicket-datetime</module>
>> >> <module>wicket-request</module>
>> >> @@ -139,7 +138,6 @@
>> >>
>> <module>wicket-objectssizeof-agent</module>
>> >> <module>wicket-examples</module>
>> >> <module>archetypes/quickstart</module>
>> >> - <module>wicket-core</module>
>> >> </modules>
>> >> <build>
>> >> <plugins>
>> >> @@ -183,7 +181,7 @@
>> >> <activeByDefault>true</activeByDefault>
>> >> </activation>
>> >> <modules>
>> >> - <module>wicket</module>
>> >> + <module>wicket-core</module>
>> >> <module>wicket-util</module>
>> >> <module>wicket-datetime</module>
>> >> <module>wicket-request</module>
>> >> @@ -199,7 +197,6 @@
>> >> <module>wicket-examples</module>
>> >> <module>archetypes/quickstart</module>
>> >>
>> <module>testing/wicket-threadtest</module>
>> >> - <module>wicket-core</module>
>> >> </modules>
>> >>
>> >> <distributionManagement>
>> >>
>> >>
>> >>
>> >
>>
>
Re: svn commit: r1053027 - /wicket/trunk/pom.xml
Posted by Martin Grigorov <mg...@apache.org>.
weird...
I just reverted your change locally and both Maven 2.2.1 and Maven 3.0.1
work without problems
On Mon, Dec 27, 2010 at 10:27 AM, Juergen Donnerstag <
juergen.donnerstag@gmail.com> wrote:
> maven 3.x complained about an error in pom.xml (did a clean checkout).
> maven did nothing. Not even clean or eclipse:eclipse did work.
>
> Juergen
>
> On Mon, Dec 27, 2010 at 10:24 AM, Martin Grigorov <mg...@apache.org>
> wrote:
> > Hi Juergen,
> >
> > What was the problem before this change ?
> >
> > The build was OK here and at Hudson (excluding the problem with
> > DatePickerTest).
> >
> > With this change 'wicket' module (three in one) is not build for none of
> the
> > profiles. I agree it is not needed for profile 'all' (active by default)
> but
> > 'wicket' module should be part of 'release' and 'apache-nexus-deploy'
> > profiles
> >
> > martin-g
> >
> > On Mon, Dec 27, 2010 at 10:09 AM, <jd...@apache.org> wrote:
> >
> >> Author: jdonnerstag
> >> Date: Mon Dec 27 09:09:16 2010
> >> New Revision: 1053027
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1053027&view=rev
> >> Log:
> >> wicket-core related change to make maven work
> >>
> >> Modified:
> >> wicket/trunk/pom.xml
> >>
> >> Modified: wicket/trunk/pom.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=1053027&r1=1053026&r2=1053027&view=diff
> >>
> >>
> ==============================================================================
> >> --- wicket/trunk/pom.xml (original)
> >> +++ wicket/trunk/pom.xml Mon Dec 27 09:09:16 2010
> >> @@ -48,7 +48,7 @@
> >> the parent.
> >> -->
> >> <modules>
> >> - <module>wicket</module>
> >> + <module>wicket-core</module>
> >> <module>wicket-util</module>
> >> <module>wicket-datetime</module>
> >> <module>wicket-request</module>
> >> @@ -63,7 +63,6 @@
> >>
> <module>wicket-objectssizeof-agent</module>
> >> <module>wicket-examples</module>
> >> <module>archetypes/quickstart</module>
> >> - <module>wicket-core</module>
> >> </modules>
> >> <build>
> >> <plugins>
> >> @@ -124,7 +123,7 @@
> >> <activeByDefault>false</activeByDefault>
> >> </activation>
> >> <modules>
> >> - <module>wicket</module>
> >> + <module>wicket-core</module>
> >> <module>wicket-util</module>
> >> <module>wicket-datetime</module>
> >> <module>wicket-request</module>
> >> @@ -139,7 +138,6 @@
> >>
> <module>wicket-objectssizeof-agent</module>
> >> <module>wicket-examples</module>
> >> <module>archetypes/quickstart</module>
> >> - <module>wicket-core</module>
> >> </modules>
> >> <build>
> >> <plugins>
> >> @@ -183,7 +181,7 @@
> >> <activeByDefault>true</activeByDefault>
> >> </activation>
> >> <modules>
> >> - <module>wicket</module>
> >> + <module>wicket-core</module>
> >> <module>wicket-util</module>
> >> <module>wicket-datetime</module>
> >> <module>wicket-request</module>
> >> @@ -199,7 +197,6 @@
> >> <module>wicket-examples</module>
> >> <module>archetypes/quickstart</module>
> >>
> <module>testing/wicket-threadtest</module>
> >> - <module>wicket-core</module>
> >> </modules>
> >>
> >> <distributionManagement>
> >>
> >>
> >>
> >
>
Re: svn commit: r1053027 - /wicket/trunk/pom.xml
Posted by Juergen Donnerstag <ju...@gmail.com>.
maven 3.x complained about an error in pom.xml (did a clean checkout).
maven did nothing. Not even clean or eclipse:eclipse did work.
Juergen
On Mon, Dec 27, 2010 at 10:24 AM, Martin Grigorov <mg...@apache.org> wrote:
> Hi Juergen,
>
> What was the problem before this change ?
>
> The build was OK here and at Hudson (excluding the problem with
> DatePickerTest).
>
> With this change 'wicket' module (three in one) is not build for none of the
> profiles. I agree it is not needed for profile 'all' (active by default) but
> 'wicket' module should be part of 'release' and 'apache-nexus-deploy'
> profiles
>
> martin-g
>
> On Mon, Dec 27, 2010 at 10:09 AM, <jd...@apache.org> wrote:
>
>> Author: jdonnerstag
>> Date: Mon Dec 27 09:09:16 2010
>> New Revision: 1053027
>>
>> URL: http://svn.apache.org/viewvc?rev=1053027&view=rev
>> Log:
>> wicket-core related change to make maven work
>>
>> Modified:
>> wicket/trunk/pom.xml
>>
>> Modified: wicket/trunk/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=1053027&r1=1053026&r2=1053027&view=diff
>>
>> ==============================================================================
>> --- wicket/trunk/pom.xml (original)
>> +++ wicket/trunk/pom.xml Mon Dec 27 09:09:16 2010
>> @@ -48,7 +48,7 @@
>> the parent.
>> -->
>> <modules>
>> - <module>wicket</module>
>> + <module>wicket-core</module>
>> <module>wicket-util</module>
>> <module>wicket-datetime</module>
>> <module>wicket-request</module>
>> @@ -63,7 +63,6 @@
>> <module>wicket-objectssizeof-agent</module>
>> <module>wicket-examples</module>
>> <module>archetypes/quickstart</module>
>> - <module>wicket-core</module>
>> </modules>
>> <build>
>> <plugins>
>> @@ -124,7 +123,7 @@
>> <activeByDefault>false</activeByDefault>
>> </activation>
>> <modules>
>> - <module>wicket</module>
>> + <module>wicket-core</module>
>> <module>wicket-util</module>
>> <module>wicket-datetime</module>
>> <module>wicket-request</module>
>> @@ -139,7 +138,6 @@
>> <module>wicket-objectssizeof-agent</module>
>> <module>wicket-examples</module>
>> <module>archetypes/quickstart</module>
>> - <module>wicket-core</module>
>> </modules>
>> <build>
>> <plugins>
>> @@ -183,7 +181,7 @@
>> <activeByDefault>true</activeByDefault>
>> </activation>
>> <modules>
>> - <module>wicket</module>
>> + <module>wicket-core</module>
>> <module>wicket-util</module>
>> <module>wicket-datetime</module>
>> <module>wicket-request</module>
>> @@ -199,7 +197,6 @@
>> <module>wicket-examples</module>
>> <module>archetypes/quickstart</module>
>> <module>testing/wicket-threadtest</module>
>> - <module>wicket-core</module>
>> </modules>
>>
>> <distributionManagement>
>>
>>
>>
>