[GitHub] [hive] kgyrtkirk commented on a change in pull request #2537: HIVE-25392: Refactor UDFToInteger to GenericUDFToInteger

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2537:
URL: https://github.com/apache/hive/pull/2537#discussion_r750457641



##########
File path: ql/src/test/results/clientpositive/llap/timestamp_1.q.out
##########
@@ -136,7 +136,7 @@ POSTHOOK: query: select cast(t as int) from timestamp_1 limit 1
 POSTHOOK: type: QUERY
 POSTHOOK: Input: default@timestamp_1
 #### A masked pattern was here ####
-1293818461
+1293843661

Review comment:
       is this change expected?

##########
File path: ql/src/test/results/clientpositive/llap/vector_non_constant_in_expr.q.out
##########
@@ -48,7 +48,7 @@ STAGE PLANS:
                 featureSupportInUse: [DECIMAL_64]
                 inputFileFormats: org.apache.hadoop.hive.ql.io.orc.OrcInputFormat
                 allNative: false
-                usesVectorUDFAdaptor: false
+                usesVectorUDFAdaptor: true

Review comment:
       this plan now uses the adaptor => the new approach misses vectorization stuff

##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
##########
@@ -737,6 +737,9 @@ public static int getInt(Object o, PrimitiveObjectInspector oi) {
       result = (int) (((TimestampObjectInspector) oi)
           .getPrimitiveWritableObject(o).getSeconds());
       break;
+    case TIMESTAMPLOCALTZ:
+      result = (int) (((TimestampLocalTZObjectInspector) oi).getPrimitiveWritableObject(o).getSeconds());

Review comment:
       I don't understand what this change has to do with this patch
   I guess the new udf uses this category; what category it used the old udf? 
   if it was a bug we could address that separately 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org